public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Preeti U Murthy <preeti@linux.vnet.ibm.com>Dietmar Eggemann
	<dietmar.eggemann@arm.com>, Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Christoph Lameter <cl@linux.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Jason Low <jason.low2@hp.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Tony Luck <tony.luck@intel.com>,
	linux390@de.ibm.com, linux-ia64@vger.kernel.org,
	linux-s390@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] sched.h: Remove useless `const' from function return type
Date: Sun, 29 Jun 2014 00:18:18 +0100 (BST)	[thread overview]
Message-ID: <alpine.LFD.2.11.1406242149270.23403@eddie.linux-mips.org> (raw)

This fixes:

cc1: warnings being treated as errors
In file included from include/linux/ptrace.h:5,
                 from arch/mips/kernel/cpu-probe.c:16:
include/linux/sched.h:1002: warning: type qualifiers ignored on function return type
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1

This is a regression introduced with commit 
143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain 
topology definition].  The warning itself is benign except in places like 
the arch/mips subtree where we use `-Werror' to enforce good coding 
practices.  Apparently the warning is GCC-version specific, some versions 
produce it and some do not.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
Vincent,

 Did you mean:

typedef int __attribute__((const)) (*sched_domain_flags_f)(void);

by any chance?

  Maciej

linux-sched-domain-flags-type.patch
Index: linux-20140623-swarm64/include/linux/sched.h
===================================================================
--- linux-20140623-swarm64.orig/include/linux/sched.h
+++ linux-20140623-swarm64/include/linux/sched.h
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do
 bool cpus_share_cache(int this_cpu, int that_cpu);
 
 typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
 
 #define SDTL_OVERLAP	0x01
 

                 reply	other threads:[~2014-06-28 23:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1406242149270.23403@eddie.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox