public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] s390: qdio: Convert timers to use timer_setup()
Date: Thu, 5 Oct 2017 19:06:30 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.21.1710051905350.1796@schleppi> (raw)
In-Reply-To: <CAGXu5jL+za1du_1kOZj1i50kXDGzY91EvLhnO5EJSQ1q1WN6NQ@mail.gmail.com>

On Thu, 5 Oct 2017, Kees Cook wrote:
> On Thu, Oct 5, 2017 at 2:13 AM, Sebastian Ott <sebott@linux.vnet.ibm.com> wrote:
> > On Wed, 4 Oct 2017, Kees Cook wrote:
> >> In preparation for unconditionally passing the struct timer_list pointer to
> >> all timer callbacks, switch to using the new timer_setup() and from_timer()
> >> to pass the timer pointer explicitly.
> >
> >> -void qdio_outbound_timer(unsigned long data)
> >> +void qdio_outbound_timer(struct timer_list *t)
> >>  {
> >> -     struct qdio_q *q = (struct qdio_q *)data;
> >> +     struct qdio_q *q = from_timer(q, t, o.out.timer);
> >                                             ^
> >                              this should be u.out.timer
> 
> Oh thank you, good catch!
> 
> > Will be applied to s390/linux.git
> 
> Did you fix this up already or should I send a v2?

Already fixed, so no V2 needed.

Sebastian

      reply	other threads:[~2017-10-05 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  0:54 [PATCH] s390: qdio: Convert timers to use timer_setup() Kees Cook
2017-10-05  9:13 ` Sebastian Ott
2017-10-05 16:58   ` Kees Cook
2017-10-05 17:06     ` Sebastian Ott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1710051905350.1796@schleppi \
    --to=sebott@linux.vnet.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=oberpar@linux.vnet.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox