From: Joe Perches <joe@perches.com>
To: Keith Busch <kbusch@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>,
Kees Cook <kees.cook@canonical.com>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;
Date: Wed, 09 Sep 2020 14:09:32 -0700 [thread overview]
Message-ID: <b0c31cbb82aa64027569dff69803ca3ec2f65501.camel@perches.com> (raw)
In-Reply-To: <20200909205558.GA3384631@dhcp-10-100-145-180.wdl.wdc.com>
On Wed, 2020-09-09 at 13:55 -0700, Keith Busch wrote:
> On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> > index eea0f453cfb6..8aac5bc60f4c 100644
> > --- a/crypto/tcrypt.c
> > +++ b/crypto/tcrypt.c
> > @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
> > test_hash_speed("streebog512", sec,
> > generic_hash_speed_template);
> > if (mode > 300 && mode < 400) break;
> > - fallthrough;
> > + break;
> > case 399:
> > break;
>
> Just imho, this change makes the preceding 'if' look even more
> pointless. Maybe the fallthrough was a deliberate choice? Not that my
> opinion matters here as I don't know this module, but it looked a bit
> odd to me.
It does look odd to me too.
It's also just a test module though so the
code isn't particularly crucial.
Herbert/David? thoughts?
next prev parent reply other threads:[~2020-09-09 21:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:06 [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Joe Perches
2020-09-09 20:38 ` Gustavo A. R. Silva
2020-09-09 20:55 ` Keith Busch
2020-09-09 21:09 ` Joe Perches [this message]
2020-09-09 22:35 ` Herbert Xu
2020-09-10 0:20 ` Joe Perches
2020-09-17 19:40 ` Jacob Keller
2020-09-09 22:36 ` Jason Gunthorpe
2020-09-09 22:47 ` Joe Perches
2020-09-10 6:28 ` Mauro Carvalho Chehab
2020-09-10 6:53 ` Wolfram Sang
2020-09-10 8:24 ` Nicolas.Ferre
2020-09-10 8:47 ` Felipe Balbi
2020-09-10 9:18 ` Steffen Maier
2020-09-10 9:24 ` Ilya Dryomov
2020-09-10 10:16 ` Matthias Brugger
2020-09-10 14:21 ` Robin Murphy
2020-09-11 4:19 ` Joe Perches
2020-09-15 9:06 ` [Intel-gfx] " Jani Nikula
2020-09-15 9:19 ` Miquel Raynal
2020-09-17 8:03 ` [oss-drivers] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0c31cbb82aa64027569dff69803ca3ec2f65501.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kbusch@kernel.org \
--cc=kees.cook@canonical.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox