From: Janosch Frank <frankja@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>,
borntraeger@linux.ibm.com, imbrenda@linux.ibm.com,
david@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v4 1/2] KVM: s390: add stat counter for shadow gmap events
Date: Mon, 9 Oct 2023 15:31:50 +0200 [thread overview]
Message-ID: <c881a0d9-4a9d-4c2a-9e37-496308674b24@linux.ibm.com> (raw)
In-Reply-To: <20231009093304.2555344-2-nrb@linux.ibm.com>
On 10/9/23 11:32, Nico Boehr wrote:
> The shadow gmap tracks memory of nested guests (guest-3). In certain
> scenarios, the shadow gmap needs to be rebuilt, which is a costly operation
> since it involves a SIE exit into guest-1 for every entry in the respective
> shadow level.
>
> Add kvm stat counters when new shadow structures are created at various
> levels. Also add a counter gmap_shadow_create when a completely fresh
> shadow gmap is created as well as a counter gmap_shadow_reuse when an
> existing gmap is being reused.
>
> Note that when several levels are shadowed at once, counters on all
> affected levels will be increased.
>
> Also note that not all page table levels need to be present and a ASCE
> can directly point to e.g. a segment table. In this case, a new segment
> table will always be equivalent to a new shadow gmap and hence will be
> counted as gmap_shadow_create and not as gmap_shadow_segment.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2023-10-09 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:32 [PATCH v4 0/2] KVM: s390: add counters for vsie performance Nico Boehr
2023-10-09 9:32 ` [PATCH v4 1/2] KVM: s390: add stat counter for shadow gmap events Nico Boehr
2023-10-09 13:20 ` Claudio Imbrenda
2023-10-09 13:31 ` Janosch Frank [this message]
2023-10-09 9:32 ` [PATCH v4 2/2] KVM: s390: add tracepoint in gmap notifier Nico Boehr
2023-10-09 13:20 ` Claudio Imbrenda
2023-10-09 13:32 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c881a0d9-4a9d-4c2a-9e37-496308674b24@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox