From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com,
pmorel@linux.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 1/8] s390x: Fix fpc store address in RESTORE_REGS_STACK
Date: Tue, 9 Feb 2021 16:14:46 +0100 [thread overview]
Message-ID: <eff04587-8499-b987-d4a8-a7a2e20fb63a@redhat.com> (raw)
In-Reply-To: <20210209134925.22248-2-frankja@linux.ibm.com>
On 09/02/2021 14.49, Janosch Frank wrote:
> The efpc stores in bits 32-63 of a register and we store a full 8
> bytes to have the stack 8 byte aligned. This means that the fpc is
> stored at offset 4 but we load it from offset 0. Lets replace efpc
> with stfpc and get rid of the stg to store at offset 0.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> s390x/macros.S | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/s390x/macros.S b/s390x/macros.S
> index 37a6a63e..e51a557a 100644
> --- a/s390x/macros.S
> +++ b/s390x/macros.S
> @@ -54,8 +54,7 @@
> .endr
> /* Save fpc, but keep stack aligned on 64bits */
> slgfi %r15, 8
> - efpc %r0
> - stg %r0, 0(%r15)
> + stfpc 0(%r15)
> .endm
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-02-09 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 13:49 [kvm-unit-tests PATCH 0/8] s390x: Cleanup exception register save/restore and implement backtrace Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 1/8] s390x: Fix fpc store address in RESTORE_REGS_STACK Janosch Frank
2021-02-09 15:14 ` Thomas Huth [this message]
2021-02-09 13:49 ` [kvm-unit-tests PATCH 2/8] s390x: Fully commit to stack save area for exceptions Janosch Frank
2021-02-11 14:47 ` Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 3/8] RFC: s390x: Define STACK_FRAME_INT_SIZE macro Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 4/8] s390x: Introduce and use CALL_INT_HANDLER macro Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 5/8] s390x: Provide preliminary backtrace support Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 6/8] s390x: Print more information on program exceptions Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 7/8] s390x: Move diag308_load_reset to stack saving Janosch Frank
2021-02-09 13:49 ` [kvm-unit-tests PATCH 8/8] s390x: Remove SAVE/RESTORE_stack Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff04587-8499-b987-d4a8-a7a2e20fb63a@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox