From: Pierre Morel <pmorel@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, cohuck@redhat.com, thuth@redhat.com,
imbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
svens@linux.ibm.com
Subject: Re: [PATCH v3 1/1] KVM: s390: vsie: clarifications on setting the APCB
Date: Fri, 17 Feb 2023 09:21:15 +0100 [thread overview]
Message-ID: <faf9b6aa-a72b-3c61-c720-6b972792f720@linux.ibm.com> (raw)
In-Reply-To: <2e1d3f81-9cc0-bf96-abde-a270a58701a1@redhat.com>
On 2/16/23 14:04, David Hildenbrand wrote:
> On 14.02.23 13:28, Pierre Morel wrote:
>> The APCB is part of the CRYCB.
>> The calculation of the APCB origin can be done by adding
>> the APCB offset to the CRYCB origin.
>>
>> Current code makes confusing transformations, converting
>> the CRYCB origin to a pointer to calculate the APCB origin.
>>
>> Let's make things simpler and keep the CRYCB origin to make
>> these calculations.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> ---
>
> Much better
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2023-02-17 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 12:28 [PATCH v3 0/1] KVM: s390: vsie: clarifications on setting the APCB Pierre Morel
2023-02-14 12:28 ` [PATCH v3 1/1] " Pierre Morel
2023-02-16 13:04 ` David Hildenbrand
2023-02-17 8:21 ` Pierre Morel [this message]
2023-02-16 13:41 ` Janosch Frank
2023-02-17 8:21 ` Pierre Morel
-- strict thread matches above, loose matches on Subject: below --
2022-11-03 15:26 [PATCH v3 0/1] " Pierre Morel
2022-11-03 15:26 ` [PATCH v3 1/1] " Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faf9b6aa-a72b-3c61-c720-6b972792f720@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox