From: sashiko-bot@kernel.org
To: "Gerd Bayer" <gbayer@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 1/3] s390/pci: Adjust alignment in insn trace
Date: Mon, 12 Oct 2026 14:26:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-168257@kernel.org> (raw)
In-Reply-To: <20261012-rpcit_trcfh_upstream-v2-1-1812db73dfa5@linux.ibm.com>
> Currently we have 64bit wide fields start at odd byte-offsets in the
> insn traces for pci_error in the s390dbf debug area, which are hard to
> decode in hex dumps. At the same time, trace entries are padded at the
> end.
>
> Drop the packed attribute on the struct definition to exploit the
> compiler's natural alignment, introduce explicit padding before and
> after the 64bit fields for humans, and add a static assertion to avoid
> accidential overruns of 2 lines in the s390dbf trace.
>
> Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-rpcit_trcfh_upstream-v2-0-1812db73dfa5@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-10-12 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 14:21 [PATCH v2 0/3] s390/pci: Updates to PCI insn tracing Gerd Bayer
2026-10-12 14:21 ` [PATCH v2 1/3] s390/pci: Adjust alignment in insn trace Gerd Bayer
2026-10-12 14:26 ` sashiko-bot [this message]
2026-10-12 15:28 ` Matthew Rosato
2026-10-12 14:21 ` [PATCH v2 2/3] s390/pci: Use 32-bit fh outside of inline asm Gerd Bayer
2026-10-12 14:28 ` sashiko-bot
2026-10-12 15:00 ` Matthew Rosato
2026-10-12 14:21 ` [PATCH v2 3/3] s390/pci: Add function handle to RPCIT insn trace Gerd Bayer
2026-10-12 14:28 ` sashiko-bot
2026-10-12 15:00 ` Matthew Rosato
2026-10-12 16:00 ` [PATCH v2 0/3] s390/pci: Updates to PCI insn tracing Heiko Carstens
2026-10-12 16:10 ` Gerd Bayer
2026-10-13 9:33 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-168257@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox