Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Gerd Bayer" <gbayer@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
	linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 3/3] s390/pci: Add function handle to RPCIT insn trace
Date: Mon, 12 Oct 2026 14:28:28 +0000	[thread overview]
Message-ID: <sashiko-outbox-168262@kernel.org> (raw)
In-Reply-To: <20261012-rpcit_trcfh_upstream-v2-3-1812db73dfa5@linux.ibm.com>

> In certain debug situations it would be helpful, if the insn trace for a
> failing RPCIT would reveal the PCI function on which this was attempted.
> 
> Introduce a variant of zpci_err_insn_req() called zpci_err_insn_rpcit()
> that accepts an IO virtual address and a range parameter together with
> the req conveying the function handle. Switch zpci_refresh_trans() to
> use that new error trace.
> 
> Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-rpcit_trcfh_upstream-v2-0-1812db73dfa5@linux.ibm.com?part=3


  reply	other threads:[~2026-10-12 14:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 14:21 [PATCH v2 0/3] s390/pci: Updates to PCI insn tracing Gerd Bayer
2026-10-12 14:21 ` [PATCH v2 1/3] s390/pci: Adjust alignment in insn trace Gerd Bayer
2026-10-12 14:26   ` sashiko-bot
2026-10-12 15:28   ` Matthew Rosato
2026-10-12 14:21 ` [PATCH v2 2/3] s390/pci: Use 32-bit fh outside of inline asm Gerd Bayer
2026-10-12 14:28   ` sashiko-bot
2026-10-12 15:00   ` Matthew Rosato
2026-10-12 14:21 ` [PATCH v2 3/3] s390/pci: Add function handle to RPCIT insn trace Gerd Bayer
2026-10-12 14:28   ` sashiko-bot [this message]
2026-10-12 15:00   ` Matthew Rosato
2026-10-12 16:00 ` [PATCH v2 0/3] s390/pci: Updates to PCI insn tracing Heiko Carstens
2026-10-12 16:10   ` Gerd Bayer
2026-10-13  9:33     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-168262@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox