Linux s390 Architecture development
 help / color / mirror / Atom feed
* [PATCH v1] s390/zcrypt: Remove the empty file
@ 2026-06-26  5:58 Rongguang Wei
  2026-06-26 13:22 ` Holger Dengler
  0 siblings, 1 reply; 6+ messages in thread
From: Rongguang Wei @ 2026-06-26  5:58 UTC (permalink / raw)
  To: linux-s390; +Cc: freude, hca, dengler, svens, Rongguang Wei

From: Rongguang Wei <weirongguang@kylinos.cn>

The files has no real user because CEX2 and CEX3 device drivers
are removed, also remove these empty files.

Fixes: 5ac8c72462cd ("s390/zcrypt: remove CEX2 and CEX3 device drivers")
Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
---
 drivers/s390/crypto/zcrypt_cex2a.c | 0
 drivers/s390/crypto/zcrypt_cex2a.h | 0
 drivers/s390/crypto/zcrypt_cex2c.c | 0
 drivers/s390/crypto/zcrypt_cex2c.h | 0
 4 files changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 drivers/s390/crypto/zcrypt_cex2a.c
 delete mode 100644 drivers/s390/crypto/zcrypt_cex2a.h
 delete mode 100644 drivers/s390/crypto/zcrypt_cex2c.c
 delete mode 100644 drivers/s390/crypto/zcrypt_cex2c.h

diff --git a/drivers/s390/crypto/zcrypt_cex2a.c b/drivers/s390/crypto/zcrypt_cex2a.c
deleted file mode 100644
index e69de29bb2d1..000000000000
diff --git a/drivers/s390/crypto/zcrypt_cex2a.h b/drivers/s390/crypto/zcrypt_cex2a.h
deleted file mode 100644
index e69de29bb2d1..000000000000
diff --git a/drivers/s390/crypto/zcrypt_cex2c.c b/drivers/s390/crypto/zcrypt_cex2c.c
deleted file mode 100644
index e69de29bb2d1..000000000000
diff --git a/drivers/s390/crypto/zcrypt_cex2c.h b/drivers/s390/crypto/zcrypt_cex2c.h
deleted file mode 100644
index e69de29bb2d1..000000000000
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] s390/zcrypt: Remove the empty file
  2026-06-26  5:58 Rongguang Wei
@ 2026-06-26 13:22 ` Holger Dengler
  0 siblings, 0 replies; 6+ messages in thread
From: Holger Dengler @ 2026-06-26 13:22 UTC (permalink / raw)
  To: Rongguang Wei; +Cc: linux-s390, freude, hca, svens, Rongguang Wei

On 6/26/26 07:58, Rongguang Wei wrote:
> From: Rongguang Wei <weirongguang@kylinos.cn>
> 
> The files has no real user because CEX2 and CEX3 device drivers
> are removed, also remove these empty files.
> 
> Fixes: 5ac8c72462cd ("s390/zcrypt: remove CEX2 and CEX3 device drivers")
> Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>

Reviewed-by: Holger Dengler <dengler@linux.ibm.com>

-- 
Mit freundlichen Grüßen / Kind regards
Holger Dengler


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] s390/mm: Fix type mismatch in get_align_mask().
@ 2026-06-30 17:32 Gerald Schaefer
  2026-07-01  6:25 ` Sven Schnelle
  2026-07-03  9:47 ` Vasily Gorbik
  0 siblings, 2 replies; 6+ messages in thread
From: Gerald Schaefer @ 2026-06-30 17:32 UTC (permalink / raw)
  To: linux-s390; +Cc: Sven Schnelle, Alexander Gordeev

Commit 86f48f922ba79 ("s390/mmap: disable mmap alignment when
randomize_va_space = 0") introduced get_align_mask() with return type of
'int', while the target field 'info.align_mask' in struct
vm_unmapped_area_info is 'unsigned long'.

With currently used masks, this should not cause truncation issues, but
fix it and return 'unsigned long' to avoid future problems.

Fixes: 86f48f922ba79 ("s390/mmap: disable mmap alignment when randomize_va_space = 0")
Cc: stable@vger.kernel.org # v6.9+
Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
---
 arch/s390/mm/mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c
index 2a222a7e14f4..ef7bfc87758c 100644
--- a/arch/s390/mm/mmap.c
+++ b/arch/s390/mm/mmap.c
@@ -64,7 +64,7 @@ static inline unsigned long mmap_base(unsigned long rnd,
 	return PAGE_ALIGN(STACK_TOP - gap - rnd);
 }
 
-static int get_align_mask(struct file *filp, unsigned long flags)
+static unsigned long get_align_mask(struct file *filp, unsigned long flags)
 {
 	if (filp && is_file_hugepages(filp))
 		return huge_page_mask_align(filp);

base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] s390/mm: Fix type mismatch in get_align_mask().
  2026-06-30 17:32 [PATCH] s390/mm: Fix type mismatch in get_align_mask() Gerald Schaefer
@ 2026-07-01  6:25 ` Sven Schnelle
  2026-07-03  9:47 ` Vasily Gorbik
  1 sibling, 0 replies; 6+ messages in thread
From: Sven Schnelle @ 2026-07-01  6:25 UTC (permalink / raw)
  To: Gerald Schaefer; +Cc: linux-s390, Alexander Gordeev

Gerald Schaefer <gerald.schaefer@linux.ibm.com> writes:

> Commit 86f48f922ba79 ("s390/mmap: disable mmap alignment when
> randomize_va_space = 0") introduced get_align_mask() with return type of
> 'int', while the target field 'info.align_mask' in struct
> vm_unmapped_area_info is 'unsigned long'.
>
> With currently used masks, this should not cause truncation issues, but
> fix it and return 'unsigned long' to avoid future problems.
>
> Fixes: 86f48f922ba79 ("s390/mmap: disable mmap alignment when randomize_va_space = 0")
> Cc: stable@vger.kernel.org # v6.9+
> Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
> ---
>  arch/s390/mm/mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c
> index 2a222a7e14f4..ef7bfc87758c 100644
> --- a/arch/s390/mm/mmap.c
> +++ b/arch/s390/mm/mmap.c
> @@ -64,7 +64,7 @@ static inline unsigned long mmap_base(unsigned long rnd,
>  	return PAGE_ALIGN(STACK_TOP - gap - rnd);
>  }
>  
> -static int get_align_mask(struct file *filp, unsigned long flags)
> +static unsigned long get_align_mask(struct file *filp, unsigned long flags)
>  {
>  	if (filp && is_file_hugepages(filp))
>  		return huge_page_mask_align(filp);
>
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482

Reviewed-by: Sven Schnelle <svens@linux.ibm.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] s390/mm: Fix type mismatch in get_align_mask().
  2026-06-30 17:32 [PATCH] s390/mm: Fix type mismatch in get_align_mask() Gerald Schaefer
  2026-07-01  6:25 ` Sven Schnelle
@ 2026-07-03  9:47 ` Vasily Gorbik
  2026-07-03  9:58   ` [PATCH v1] s390/zcrypt: Remove the empty file Vasily Gorbik
  1 sibling, 1 reply; 6+ messages in thread
From: Vasily Gorbik @ 2026-07-03  9:47 UTC (permalink / raw)
  To: Gerald Schaefer; +Cc: linux-s390, Sven Schnelle, Alexander Gordeev

On Tue, Jun 30, 2026 at 07:32:14PM +0200, Gerald Schaefer wrote:
> Commit 86f48f922ba79 ("s390/mmap: disable mmap alignment when
> randomize_va_space = 0") introduced get_align_mask() with return type of
> 'int', while the target field 'info.align_mask' in struct
> vm_unmapped_area_info is 'unsigned long'.
> 
> With currently used masks, this should not cause truncation issues, but
> fix it and return 'unsigned long' to avoid future problems.
> 
> Fixes: 86f48f922ba79 ("s390/mmap: disable mmap alignment when randomize_va_space = 0")
> Cc: stable@vger.kernel.org # v6.9+
> Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
> ---
>  arch/s390/mm/mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thank you!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] s390/zcrypt: Remove the empty file
  2026-07-03  9:47 ` Vasily Gorbik
@ 2026-07-03  9:58   ` Vasily Gorbik
  0 siblings, 0 replies; 6+ messages in thread
From: Vasily Gorbik @ 2026-07-03  9:58 UTC (permalink / raw)
  To: Rongguang Wei; +Cc: linux-s390, freude, hca, dengler, svens, Rongguang Wei

On Fri, Jun 26, 2026 at 01:58:20PM +0800, Rongguang Wei wrote:
> From: Rongguang Wei <weirongguang@kylinos.cn>
> 
> The files has no real user because CEX2 and CEX3 device drivers
> are removed, also remove these empty files.
> 
> Fixes: 5ac8c72462cd ("s390/zcrypt: remove CEX2 and CEX3 device drivers")
> Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
> ---
>  drivers/s390/crypto/zcrypt_cex2a.c | 0
>  drivers/s390/crypto/zcrypt_cex2a.h | 0
>  drivers/s390/crypto/zcrypt_cex2c.c | 0
>  drivers/s390/crypto/zcrypt_cex2c.h | 0
>  4 files changed, 0 insertions(+), 0 deletions(-)
>  delete mode 100644 drivers/s390/crypto/zcrypt_cex2a.c
>  delete mode 100644 drivers/s390/crypto/zcrypt_cex2a.h
>  delete mode 100644 drivers/s390/crypto/zcrypt_cex2c.c
>  delete mode 100644 drivers/s390/crypto/zcrypt_cex2c.h

Applied, thank you!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-03  9:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 17:32 [PATCH] s390/mm: Fix type mismatch in get_align_mask() Gerald Schaefer
2026-07-01  6:25 ` Sven Schnelle
2026-07-03  9:47 ` Vasily Gorbik
2026-07-03  9:58   ` [PATCH v1] s390/zcrypt: Remove the empty file Vasily Gorbik
  -- strict thread matches above, loose matches on Subject: below --
2026-06-26  5:58 Rongguang Wei
2026-06-26 13:22 ` Holger Dengler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox