* [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
@ 2026-07-01 13:47 Thomas Huth
2026-07-08 12:47 ` Alexander Gordeev
2026-07-09 10:42 ` Vasily Gorbik
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Huth @ 2026-07-01 13:47 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev; +Cc: linux-s390, linux-kernel
From: Thomas Huth <thuth@redhat.com>
unistd_32.h is not build anymore since commit 4ac286c4a8d90
("s390/syscalls: Switch to generic system call table generation").
Thus drop the superfluous line from the Kbuild file now, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
arch/s390/include/uapi/asm/Kbuild | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/include/uapi/asm/Kbuild b/arch/s390/include/uapi/asm/Kbuild
index 46c1ff0b842a1..378151cef3cce 100644
--- a/arch/s390/include/uapi/asm/Kbuild
+++ b/arch/s390/include/uapi/asm/Kbuild
@@ -1,4 +1,3 @@
# SPDX-License-Identifier: GPL-2.0
-generated-y += unistd_32.h
generated-y += unistd_64.h
--
2.54.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
2026-07-01 13:47 [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file Thomas Huth
@ 2026-07-08 12:47 ` Alexander Gordeev
2026-07-09 5:57 ` Heiko Carstens
2026-07-09 10:42 ` Vasily Gorbik
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2026-07-08 12:47 UTC (permalink / raw)
To: Thomas Huth; +Cc: Heiko Carstens, Vasily Gorbik, linux-s390, linux-kernel
On Wed, Jul 01, 2026 at 03:47:27PM +0200, Thomas Huth wrote:
Hi Thomas,
> From: Thomas Huth <thuth@redhat.com>
>
> unistd_32.h is not build anymore since commit 4ac286c4a8d90
> ("s390/syscalls: Switch to generic system call table generation").
> Thus drop the superfluous line from the Kbuild file now, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> arch/s390/include/uapi/asm/Kbuild | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/include/uapi/asm/Kbuild b/arch/s390/include/uapi/asm/Kbuild
> index 46c1ff0b842a1..378151cef3cce 100644
> --- a/arch/s390/include/uapi/asm/Kbuild
> +++ b/arch/s390/include/uapi/asm/Kbuild
> @@ -1,4 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -generated-y += unistd_32.h
> generated-y += unistd_64.h
On repeated builds it results in:
SYSHDR arch/s390/include/generated/uapi/asm/unistd_32.h
REMOVE arch/s390/include/generated/uapi/asm/unistd_32.h
A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
at least, but we still might want to have unistd_32.h around.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
2026-07-08 12:47 ` Alexander Gordeev
@ 2026-07-09 5:57 ` Heiko Carstens
2026-07-09 6:59 ` Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2026-07-09 5:57 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: Thomas Huth, Vasily Gorbik, linux-s390, linux-kernel
On Wed, Jul 08, 2026 at 02:47:01PM +0200, Alexander Gordeev wrote:
> On Wed, Jul 01, 2026 at 03:47:27PM +0200, Thomas Huth wrote:
>
> Hi Thomas,
>
> > From: Thomas Huth <thuth@redhat.com>
> >
> > unistd_32.h is not build anymore since commit 4ac286c4a8d90
> > ("s390/syscalls: Switch to generic system call table generation").
> > Thus drop the superfluous line from the Kbuild file now, too.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > arch/s390/include/uapi/asm/Kbuild | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/s390/include/uapi/asm/Kbuild b/arch/s390/include/uapi/asm/Kbuild
> > index 46c1ff0b842a1..378151cef3cce 100644
> > --- a/arch/s390/include/uapi/asm/Kbuild
> > +++ b/arch/s390/include/uapi/asm/Kbuild
> > @@ -1,4 +1,3 @@
> > # SPDX-License-Identifier: GPL-2.0
> >
> > -generated-y += unistd_32.h
> > generated-y += unistd_64.h
>
> On repeated builds it results in:
>
> SYSHDR arch/s390/include/generated/uapi/asm/unistd_32.h
> REMOVE arch/s390/include/generated/uapi/asm/unistd_32.h
How did you achieve that unistd_32.h is actually generated? The required
syscall table information to generate such a header file is not present.
This looks very odd to me.
The above should be impossible with current upstream code, and I cannot
reproduce it. Any chance you applied Thomas' patch on top of an old commit
which still includes compat support?
> A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
> at least,
I don't think so.
> but we still might want to have unistd_32.h around.
No, that doesn't make sense. compat support is completely gone, including all
header files. The patch looks fine as it is for me, but we need to sort out
what you reported.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
2026-07-09 5:57 ` Heiko Carstens
@ 2026-07-09 6:59 ` Alexander Gordeev
2026-07-09 10:16 ` Vasily Gorbik
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2026-07-09 6:59 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Thomas Huth, Vasily Gorbik, linux-s390, linux-kernel
On Thu, Jul 09, 2026 at 07:57:15AM +0200, Heiko Carstens wrote:
> > On repeated builds it results in:
> >
> > SYSHDR arch/s390/include/generated/uapi/asm/unistd_32.h
> > REMOVE arch/s390/include/generated/uapi/asm/unistd_32.h
>
> How did you achieve that unistd_32.h is actually generated? The required
> syscall table information to generate such a header file is not present.
> This looks very odd to me.
>
> The above should be impossible with current upstream code, and I cannot
> reproduce it. Any chance you applied Thomas' patch on top of an old commit
> which still includes compat support?
I can not reproduce it anymore of course, but I am pretty sure I was
trying exactly that :/
> > A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
> > at least,
>
> I don't think so.
>
> > but we still might want to have unistd_32.h around.
>
> No, that doesn't make sense. compat support is completely gone, including all
> header files. The patch looks fine as it is for me, but we need to sort out
> what you reported.
Yes, my report is false. Sorry for the noise.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
2026-07-09 6:59 ` Alexander Gordeev
@ 2026-07-09 10:16 ` Vasily Gorbik
0 siblings, 0 replies; 6+ messages in thread
From: Vasily Gorbik @ 2026-07-09 10:16 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: Heiko Carstens, Thomas Huth, linux-s390, linux-kernel
On Thu, Jul 09, 2026 at 08:59:23AM +0200, Alexander Gordeev wrote:
> On Thu, Jul 09, 2026 at 07:57:15AM +0200, Heiko Carstens wrote:
> > > On repeated builds it results in:
> > >
> > > SYSHDR arch/s390/include/generated/uapi/asm/unistd_32.h
> > > REMOVE arch/s390/include/generated/uapi/asm/unistd_32.h
> >
> > How did you achieve that unistd_32.h is actually generated? The required
> > syscall table information to generate such a header file is not present.
> > This looks very odd to me.
> >
> > The above should be impossible with current upstream code, and I cannot
> > reproduce it. Any chance you applied Thomas' patch on top of an old commit
> > which still includes compat support?
>
> I can not reproduce it anymore of course, but I am pretty sure I was
> trying exactly that :/
>
> > > A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
> > > at least,
> >
> > I don't think so.
> >
> > > but we still might want to have unistd_32.h around.
> >
> > No, that doesn't make sense. compat support is completely gone, including all
> > header files. The patch looks fine as it is for me, but we need to sort out
> > what you reported.
>
> Yes, my report is false. Sorry for the noise.
Maybe you have not started with a clean tree.
Anyhow, I'm picking up this patch then.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
2026-07-01 13:47 [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file Thomas Huth
2026-07-08 12:47 ` Alexander Gordeev
@ 2026-07-09 10:42 ` Vasily Gorbik
1 sibling, 0 replies; 6+ messages in thread
From: Vasily Gorbik @ 2026-07-09 10:42 UTC (permalink / raw)
To: Thomas Huth; +Cc: Heiko Carstens, Alexander Gordeev, linux-s390, linux-kernel
On Wed, Jul 01, 2026 at 03:47:27PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> unistd_32.h is not build anymore since commit 4ac286c4a8d90
> ("s390/syscalls: Switch to generic system call table generation").
> Thus drop the superfluous line from the Kbuild file now, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> arch/s390/include/uapi/asm/Kbuild | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Vasily Gorbik <gor@linux.ibm.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-09 10:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 13:47 [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file Thomas Huth
2026-07-08 12:47 ` Alexander Gordeev
2026-07-09 5:57 ` Heiko Carstens
2026-07-09 6:59 ` Alexander Gordeev
2026-07-09 10:16 ` Vasily Gorbik
2026-07-09 10:42 ` Vasily Gorbik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox