* [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration
@ 2019-07-09 12:25 Denis Efremov
2019-07-10 6:44 ` Harald Freudenberger
0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2019-07-09 12:25 UTC (permalink / raw)
To: Harald Freudenberger
Cc: Denis Efremov, Martin Schwidefsky, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, linux-s390, linux-kernel
The function ap_query_configuration is declared static and marked
EXPORT_SYMBOL, which is at best an odd combination. Because the
function is not used outside of the drivers/s390/crypto/ap_bus.c
file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
Fixes: f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
Fixes: 050349b5b71d ("s390/zcrypt: externalize AP config info query")
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/s390/crypto/ap_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index b9fc502c58c2..379e43b79006 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
return -EINVAL;
return ap_qci(info);
}
-EXPORT_SYMBOL(ap_query_configuration);
/**
* ap_init_configuration(): Allocate and query configuration array.
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration
2019-07-09 12:25 [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration Denis Efremov
@ 2019-07-10 6:44 ` Harald Freudenberger
2019-07-11 13:52 ` Vasily Gorbik
0 siblings, 1 reply; 3+ messages in thread
From: Harald Freudenberger @ 2019-07-10 6:44 UTC (permalink / raw)
To: Denis Efremov
Cc: Martin Schwidefsky, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, linux-s390, linux-kernel
On 09.07.19 14:25, Denis Efremov wrote:
> The function ap_query_configuration is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the
> function is not used outside of the drivers/s390/crypto/ap_bus.c
> file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
>
> Fixes: f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
> Fixes: 050349b5b71d ("s390/zcrypt: externalize AP config info query")
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/s390/crypto/ap_bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
> index b9fc502c58c2..379e43b79006 100644
> --- a/drivers/s390/crypto/ap_bus.c
> +++ b/drivers/s390/crypto/ap_bus.c
> @@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
> return -EINVAL;
> return ap_qci(info);
> }
> -EXPORT_SYMBOL(ap_query_configuration);
>
> /**
> * ap_init_configuration(): Allocate and query configuration array.
This function was exported a while ago for KVM code. However, never used.
So removing the export is the right thing. Thanks Denis
Heiko/Vasily will you pick this patch please?
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration
2019-07-10 6:44 ` Harald Freudenberger
@ 2019-07-11 13:52 ` Vasily Gorbik
0 siblings, 0 replies; 3+ messages in thread
From: Vasily Gorbik @ 2019-07-11 13:52 UTC (permalink / raw)
To: Harald Freudenberger
Cc: Denis Efremov, Heiko Carstens, Christian Borntraeger, linux-s390,
linux-kernel
On Wed, Jul 10, 2019 at 08:44:53AM +0200, Harald Freudenberger wrote:
> On 09.07.19 14:25, Denis Efremov wrote:
> > The function ap_query_configuration is declared static and marked
> > EXPORT_SYMBOL, which is at best an odd combination. Because the
> > function is not used outside of the drivers/s390/crypto/ap_bus.c
> > file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
> >
> > Fixes: f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
> > Fixes: 050349b5b71d ("s390/zcrypt: externalize AP config info query")
> > Signed-off-by: Denis Efremov <efremov@linux.com>
> > ---
> > drivers/s390/crypto/ap_bus.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
> > index b9fc502c58c2..379e43b79006 100644
> > --- a/drivers/s390/crypto/ap_bus.c
> > +++ b/drivers/s390/crypto/ap_bus.c
> > @@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
> > return -EINVAL;
> > return ap_qci(info);
> > }
> > -EXPORT_SYMBOL(ap_query_configuration);
> >
> > /**
> > * ap_init_configuration(): Allocate and query configuration array.
> This function was exported a while ago for KVM code. However, never used.
> So removing the export is the right thing. Thanks Denis
>
> Heiko/Vasily will you pick this patch please?
>
> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-11 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-09 12:25 [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration Denis Efremov
2019-07-10 6:44 ` Harald Freudenberger
2019-07-11 13:52 ` Vasily Gorbik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox