* [PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros
@ 2024-06-16 3:01 Jeff Johnson
2024-06-19 22:45 ` Vasily Gorbik
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-06-16 3:01 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev,
Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors, Jeff Johnson
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/raw3270.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/con3270.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/fs3270.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/s390/char/con3270.c | 1 +
drivers/s390/char/fs3270.c | 1 +
drivers/s390/char/raw3270.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index 251d2a1c3eef..053102d0fcd2 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -2185,6 +2185,7 @@ con3270_init(void)
console_initcall(con3270_init);
#endif
+MODULE_DESCRIPTION("IBM/3270 Driver - tty functions");
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(IBM_TTY3270_MAJOR);
diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
index 4d824f86bbbb..61515781c5dd 100644
--- a/drivers/s390/char/fs3270.c
+++ b/drivers/s390/char/fs3270.c
@@ -559,6 +559,7 @@ static void __exit fs3270_exit(void)
__unregister_chrdev(IBM_FS3270_MAJOR, 0, 1, "fs3270");
}
+MODULE_DESCRIPTION("IBM/3270 Driver - fullscreen driver");
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(IBM_FS3270_MAJOR);
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index c57694be9bd3..ba3d7114b34f 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1341,6 +1341,7 @@ static void raw3270_exit(void)
class_unregister(&class3270);
}
+MODULE_DESCRIPTION("IBM/3270 Driver - core functions");
MODULE_LICENSE("GPL");
module_init(raw3270_init);
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-char-94fad7b2de6d
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros
2024-06-16 3:01 [PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-19 22:45 ` Vasily Gorbik
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Gorbik @ 2024-06-19 22:45 UTC (permalink / raw)
To: Jeff Johnson
Cc: Heiko Carstens, Alexander Gordeev, Christian Borntraeger,
Sven Schnelle, linux-s390, linux-kernel, kernel-janitors
On Sat, Jun 15, 2024 at 08:01:17PM -0700, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/raw3270.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/con3270.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/fs3270.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/s390/char/con3270.c | 1 +
> drivers/s390/char/fs3270.c | 1 +
> drivers/s390/char/raw3270.c | 1 +
> 3 files changed, 3 insertions(+)
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-19 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-16 3:01 [PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-19 22:45 ` Vasily Gorbik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox