* [PATCH v2] s390/cio: add missing MODULE_DESCRIPTION() macros
@ 2024-07-15 15:58 Jeff Johnson
2024-07-26 11:14 ` Vasily Gorbik
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-07-15 15:58 UTC (permalink / raw)
To: Vineeth Vijayan, Peter Oberparleiter, Heiko Carstens,
Vasily Gorbik, Alexander Gordeev, Christian Borntraeger,
Sven Schnelle, Eric Farman, Matthew Rosato, Halil Pasic
Cc: linux-s390, linux-kernel, kvm, kernel-janitors, Jeff Johnson
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
I hope this can get into the 6.11 merge window.
I originally had almost 300 patches to fix these issues treewide, and
this is one of only 13 left which have not landed in linux-next
---
Changes in v2:
- changed CCW Group to ccwgroup in ccwgroup.c description
- removed "Physical" in vfio_ccw_drv.c description
- applied Reviewed-by tags from Eric Farman & Vineeth Vijayan since these edits
seem to be aligned with their comments
- Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-cio-v1-1-8fc9584e8595@quicinc.com
---
drivers/s390/cio/ccwgroup.c | 1 +
drivers/s390/cio/vfio_ccw_drv.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index b72f672a7720..66b1bdc63284 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -550,4 +550,5 @@ void ccwgroup_remove_ccwdev(struct ccw_device *cdev)
put_device(&gdev->dev);
}
EXPORT_SYMBOL(ccwgroup_remove_ccwdev);
+MODULE_DESCRIPTION("ccwgroup bus driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 8ad49030a7bf..914dde041675 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -488,4 +488,5 @@ static void __exit vfio_ccw_sch_exit(void)
module_init(vfio_ccw_sch_init);
module_exit(vfio_ccw_sch_exit);
+MODULE_DESCRIPTION("VFIO based Subchannel device driver");
MODULE_LICENSE("GPL v2");
---
base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
change-id: 20240615-md-s390-drivers-s390-cio-3598abb802ad
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] s390/cio: add missing MODULE_DESCRIPTION() macros
2024-07-15 15:58 [PATCH v2] s390/cio: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-07-26 11:14 ` Vasily Gorbik
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Gorbik @ 2024-07-26 11:14 UTC (permalink / raw)
To: Jeff Johnson
Cc: Vineeth Vijayan, Peter Oberparleiter, Heiko Carstens,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
Eric Farman, Matthew Rosato, Halil Pasic, linux-s390,
linux-kernel, kvm, kernel-janitors
On Mon, Jul 15, 2024 at 08:58:51AM -0700, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> I hope this can get into the 6.11 merge window.
> I originally had almost 300 patches to fix these issues treewide, and
> this is one of only 13 left which have not landed in linux-next
> ---
> Changes in v2:
> - changed CCW Group to ccwgroup in ccwgroup.c description
> - removed "Physical" in vfio_ccw_drv.c description
> - applied Reviewed-by tags from Eric Farman & Vineeth Vijayan since these edits
> seem to be aligned with their comments
> - Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-cio-v1-1-8fc9584e8595@quicinc.com
> ---
> drivers/s390/cio/ccwgroup.c | 1 +
> drivers/s390/cio/vfio_ccw_drv.c | 1 +
> 2 files changed, 2 insertions(+)
Applied, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-26 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 15:58 [PATCH v2] s390/cio: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-07-26 11:14 ` Vasily Gorbik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox