* Re: [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls [not found] ` <20230120162650.984577-16-Liam.Howlett@oracle.com> @ 2023-01-25 11:00 ` Sven Schnelle 2023-01-25 13:53 ` Liam R. Howlett 0 siblings, 1 reply; 2+ messages in thread From: Sven Schnelle @ 2023-01-25 11:00 UTC (permalink / raw) To: Liam R. Howlett Cc: linux-mm, linux-kernel, Andrew Morton, maple-tree, linux-s390 Hi Liam, "Liam R. Howlett" <Liam.Howlett@oracle.com> writes: > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com> > > Pass through the vma iterator to do_vmi_munmap() to handle the iterator > state internally > > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com> > --- > ipc/shm.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) git bisect says this breaks the shm* testcase in ltp on (at least) s390: # ./test.sh tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s shmat01.c:124: TPASS: shmat() succeeded to attach NULL address shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) Summary: passed 1 failed 3 broken 0 skipped 0 warnings 0 # Can you take a look? Thanks! reverting the above commit fixes the issue. Thanks, Sven ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls 2023-01-25 11:00 ` [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls Sven Schnelle @ 2023-01-25 13:53 ` Liam R. Howlett 0 siblings, 0 replies; 2+ messages in thread From: Liam R. Howlett @ 2023-01-25 13:53 UTC (permalink / raw) To: Sven Schnelle Cc: linux-mm, linux-kernel, Andrew Morton, maple-tree, linux-s390 * Sven Schnelle <svens@linux.ibm.com> [230125 06:00]: > Hi Liam, > > "Liam R. Howlett" <Liam.Howlett@oracle.com> writes: > > > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com> > > > > Pass through the vma iterator to do_vmi_munmap() to handle the iterator > > state internally > > > > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com> > > --- > > ipc/shm.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > git bisect says this breaks the shm* testcase in ltp on (at least) s390: > > # ./test.sh > tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s > shmat01.c:124: TPASS: shmat() succeeded to attach NULL address > shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) > shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) > shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) > > Summary: > passed 1 > failed 3 > broken 0 > skipped 0 > warnings 0 > > # > > Can you take a look? Thanks! > > reverting the above commit fixes the issue. Thanks for testing this and letting me know. I'll have a look. Regards, Liam ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-25 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230120162650.984577-1-Liam.Howlett@oracle.com>
[not found] ` <20230120162650.984577-16-Liam.Howlett@oracle.com>
2023-01-25 11:00 ` [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls Sven Schnelle
2023-01-25 13:53 ` Liam R. Howlett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox