From: Sven Schnelle <svens@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Nathan Chancellor <nathan@kernel.org>, linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390/ftrace: use la instead of aghik in return_to_handler()
Date: Wed, 26 Jul 2023 09:15:06 +0200 [thread overview]
Message-ID: <yt9do7jz4005.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230726061834.1300984-1-hca@linux.ibm.com> (Heiko Carstens's message of "Wed, 26 Jul 2023 08:18:34 +0200")
Heiko Carstens <hca@linux.ibm.com> writes:
> Nathan Chancellor reported the following build error when compiling the
> kernel with CONFIG_MARCH_Z10=y:
>
> arch/s390/kernel/mcount.S: Assembler messages:
> arch/s390/kernel/mcount.S:140: Error: Unrecognized opcode: `aghik'
>
> The aghik instruction is only available since z196. Use the la instruction
> instead which is available for all machines.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Closes: https://lore.kernel.org/all/20230725211105.GA224840@dev-arch.thelio-3990X
> Fixes: 1256e70a082a ("s390/ftrace: enable HAVE_FUNCTION_GRAPH_RETVAL")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/kernel/mcount.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/mcount.S b/arch/s390/kernel/mcount.S
> index d2596e0df6fa..71c5fa05e7f1 100644
> --- a/arch/s390/kernel/mcount.S
> +++ b/arch/s390/kernel/mcount.S
> @@ -137,7 +137,7 @@ SYM_FUNC_START(return_to_handler)
> lgr %r1,%r15
> aghi %r15,-(STACK_FRAME_OVERHEAD+__FGRAPH_RET_SIZE)
> stg %r1,__SF_BACKCHAIN(%r15)
> - aghik %r3,%r15,STACK_FRAME_OVERHEAD
> + la %r3,STACK_FRAME_OVERHEAD(%r15)
> stg %r1,__FGRAPH_RET_FP(%r3)
> stg %r2,__FGRAPH_RET_GPR2(%r3)
> lgr %r2,%r3
Reviewed-by: Sven Schnelle <svens@linux.ibm.com>
next prev parent reply other threads:[~2023-07-26 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 6:18 [PATCH] s390/ftrace: use la instead of aghik in return_to_handler() Heiko Carstens
2023-07-26 7:15 ` Sven Schnelle [this message]
2023-07-26 15:20 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9do7jz4005.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox