* [PATCH] s390/ftrace: use la instead of aghik in return_to_handler()
@ 2023-07-26 6:18 Heiko Carstens
2023-07-26 7:15 ` Sven Schnelle
2023-07-26 15:20 ` Nathan Chancellor
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Carstens @ 2023-07-26 6:18 UTC (permalink / raw)
To: Nathan Chancellor, Sven Schnelle; +Cc: linux-s390
Nathan Chancellor reported the following build error when compiling the
kernel with CONFIG_MARCH_Z10=y:
arch/s390/kernel/mcount.S: Assembler messages:
arch/s390/kernel/mcount.S:140: Error: Unrecognized opcode: `aghik'
The aghik instruction is only available since z196. Use the la instruction
instead which is available for all machines.
Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://lore.kernel.org/all/20230725211105.GA224840@dev-arch.thelio-3990X
Fixes: 1256e70a082a ("s390/ftrace: enable HAVE_FUNCTION_GRAPH_RETVAL")
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
arch/s390/kernel/mcount.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kernel/mcount.S b/arch/s390/kernel/mcount.S
index d2596e0df6fa..71c5fa05e7f1 100644
--- a/arch/s390/kernel/mcount.S
+++ b/arch/s390/kernel/mcount.S
@@ -137,7 +137,7 @@ SYM_FUNC_START(return_to_handler)
lgr %r1,%r15
aghi %r15,-(STACK_FRAME_OVERHEAD+__FGRAPH_RET_SIZE)
stg %r1,__SF_BACKCHAIN(%r15)
- aghik %r3,%r15,STACK_FRAME_OVERHEAD
+ la %r3,STACK_FRAME_OVERHEAD(%r15)
stg %r1,__FGRAPH_RET_FP(%r3)
stg %r2,__FGRAPH_RET_GPR2(%r3)
lgr %r2,%r3
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] s390/ftrace: use la instead of aghik in return_to_handler()
2023-07-26 6:18 [PATCH] s390/ftrace: use la instead of aghik in return_to_handler() Heiko Carstens
@ 2023-07-26 7:15 ` Sven Schnelle
2023-07-26 15:20 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Sven Schnelle @ 2023-07-26 7:15 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Nathan Chancellor, linux-s390
Heiko Carstens <hca@linux.ibm.com> writes:
> Nathan Chancellor reported the following build error when compiling the
> kernel with CONFIG_MARCH_Z10=y:
>
> arch/s390/kernel/mcount.S: Assembler messages:
> arch/s390/kernel/mcount.S:140: Error: Unrecognized opcode: `aghik'
>
> The aghik instruction is only available since z196. Use the la instruction
> instead which is available for all machines.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Closes: https://lore.kernel.org/all/20230725211105.GA224840@dev-arch.thelio-3990X
> Fixes: 1256e70a082a ("s390/ftrace: enable HAVE_FUNCTION_GRAPH_RETVAL")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/kernel/mcount.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/mcount.S b/arch/s390/kernel/mcount.S
> index d2596e0df6fa..71c5fa05e7f1 100644
> --- a/arch/s390/kernel/mcount.S
> +++ b/arch/s390/kernel/mcount.S
> @@ -137,7 +137,7 @@ SYM_FUNC_START(return_to_handler)
> lgr %r1,%r15
> aghi %r15,-(STACK_FRAME_OVERHEAD+__FGRAPH_RET_SIZE)
> stg %r1,__SF_BACKCHAIN(%r15)
> - aghik %r3,%r15,STACK_FRAME_OVERHEAD
> + la %r3,STACK_FRAME_OVERHEAD(%r15)
> stg %r1,__FGRAPH_RET_FP(%r3)
> stg %r2,__FGRAPH_RET_GPR2(%r3)
> lgr %r2,%r3
Reviewed-by: Sven Schnelle <svens@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] s390/ftrace: use la instead of aghik in return_to_handler()
2023-07-26 6:18 [PATCH] s390/ftrace: use la instead of aghik in return_to_handler() Heiko Carstens
2023-07-26 7:15 ` Sven Schnelle
@ 2023-07-26 15:20 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2023-07-26 15:20 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Sven Schnelle, linux-s390
On Wed, Jul 26, 2023 at 08:18:34AM +0200, Heiko Carstens wrote:
> Nathan Chancellor reported the following build error when compiling the
> kernel with CONFIG_MARCH_Z10=y:
>
> arch/s390/kernel/mcount.S: Assembler messages:
> arch/s390/kernel/mcount.S:140: Error: Unrecognized opcode: `aghik'
>
> The aghik instruction is only available since z196. Use the la instruction
> instead which is available for all machines.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Closes: https://lore.kernel.org/all/20230725211105.GA224840@dev-arch.thelio-3990X
> Fixes: 1256e70a082a ("s390/ftrace: enable HAVE_FUNCTION_GRAPH_RETVAL")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
> ---
> arch/s390/kernel/mcount.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/mcount.S b/arch/s390/kernel/mcount.S
> index d2596e0df6fa..71c5fa05e7f1 100644
> --- a/arch/s390/kernel/mcount.S
> +++ b/arch/s390/kernel/mcount.S
> @@ -137,7 +137,7 @@ SYM_FUNC_START(return_to_handler)
> lgr %r1,%r15
> aghi %r15,-(STACK_FRAME_OVERHEAD+__FGRAPH_RET_SIZE)
> stg %r1,__SF_BACKCHAIN(%r15)
> - aghik %r3,%r15,STACK_FRAME_OVERHEAD
> + la %r3,STACK_FRAME_OVERHEAD(%r15)
> stg %r1,__FGRAPH_RET_FP(%r3)
> stg %r2,__FGRAPH_RET_GPR2(%r3)
> lgr %r2,%r3
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-26 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 6:18 [PATCH] s390/ftrace: use la instead of aghik in return_to_handler() Heiko Carstens
2023-07-26 7:15 ` Sven Schnelle
2023-07-26 15:20 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox