[PATCH v2] trace-cmd: fix writing of uncompressed size

[PATCH v2] trace-cmd: fix writing of uncompressed size

[Sven Schnelle]

pointer in struct tracecmd_compression is 'unsigned long', which is 8 byte
in size on most platforms, but the tep_read_number() call in the next line
treats it as a 4 byte value. As there's no need for unsigned long change
the type to unsigned int.

Fixes: 3f8447b1 ("trace-cmd library: Add support for compression algorithms")
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
 lib/trace-cmd/trace-compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/trace-cmd/trace-compress.c b/lib/trace-cmd/trace-compress.c
index a63295e..461de8d 100644
--- a/lib/trace-cmd/trace-compress.c
+++ b/lib/trace-cmd/trace-compress.c
@@ -32,7 +32,7 @@ struct tracecmd_compression {
 	int				fd;
 	unsigned int			capacity;
 	unsigned int			capacity_read;
-	unsigned long			pointer;
+	unsigned int			pointer;
 	char				*buffer;
 	struct compress_proto		*proto;
 	struct tep_handle		*tep;
-- 
2.36.1

Re: [PATCH v2] trace-cmd: fix writing of uncompressed size

[Tzvetomir Stoyanov]

On Mon, Jul 11, 2022 at 12:43 PM Sven Schnelle <svens@linux.ibm.com> wrote:
>
> pointer in struct tracecmd_compression is 'unsigned long', which is 8 byte
> in size on most platforms, but the tep_read_number() call in the next line
> treats it as a 4 byte value. As there's no need for unsigned long change
> the type to unsigned int.
>
> Fixes: 3f8447b1 ("trace-cmd library: Add support for compression algorithms")
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>

Acked-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>

Thanks!

> ---
>  lib/trace-cmd/trace-compress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/trace-cmd/trace-compress.c b/lib/trace-cmd/trace-compress.c
> index a63295e..461de8d 100644
> --- a/lib/trace-cmd/trace-compress.c
> +++ b/lib/trace-cmd/trace-compress.c
> @@ -32,7 +32,7 @@ struct tracecmd_compression {
>         int                             fd;
>         unsigned int                    capacity;
>         unsigned int                    capacity_read;
> -       unsigned long                   pointer;
> +       unsigned int                    pointer;
>         char                            *buffer;
>         struct compress_proto           *proto;
>         struct tep_handle               *tep;
> --
> 2.36.1
>


-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center

Re: [PATCH v2] trace-cmd: fix writing of uncompressed size

[Steven Rostedt]

On Mon, 11 Jul 2022 11:43:40 +0200
Sven Schnelle <svens@linux.ibm.com> wrote:

> pointer in struct tracecmd_compression is 'unsigned long', which is 8 byte
> in size on most platforms, but the tep_read_number() call in the next line
> treats it as a 4 byte value. As there's no need for unsigned long change
> the type to unsigned int.
> 
> Fixes: 3f8447b1 ("trace-cmd library: Add support for compression algorithms")
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>

Hi Sven,

Can you resend and Cc linux-trace-devel@vger.kernel.org so that it gets
added to patchwork.

Thanks!

-- Steve


> ---
>  lib/trace-cmd/trace-compress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/trace-cmd/trace-compress.c b/lib/trace-cmd/trace-compress.c
> index a63295e..461de8d 100644
> --- a/lib/trace-cmd/trace-compress.c
> +++ b/lib/trace-cmd/trace-compress.c
> @@ -32,7 +32,7 @@ struct tracecmd_compression {
>  	int				fd;
>  	unsigned int			capacity;
>  	unsigned int			capacity_read;
> -	unsigned long			pointer;
> +	unsigned int			pointer;
>  	char				*buffer;
>  	struct compress_proto		*proto;
>  	struct tep_handle		*tep;

Re: [PATCH v2] trace-cmd: fix writing of uncompressed size

[Steven Rostedt]

On Mon, 11 Jul 2022 13:51:46 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Can you resend and Cc linux-trace-devel@vger.kernel.org so that it gets
> added to patchwork.

Actually, I'll just send it for you ;-)

-- Steve

Re: [PATCH v2] trace-cmd: fix writing of uncompressed size

[Sven Schnelle]

Hi Steve,

Steven Rostedt <rostedt@goodmis.org> writes:

> On Mon, 11 Jul 2022 13:51:46 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> Can you resend and Cc linux-trace-devel@vger.kernel.org so that it gets
>> added to patchwork.
>
> Actually, I'll just send it for you ;-)

Thank you! :-)