From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Mark Brown' <broonie@opensource.wolfsonmicro.com>
Cc: 'Ben Dooks' <ben-linux@fluff.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: RE: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs
Date: Wed, 01 Dec 2010 21:11:21 +0900 [thread overview]
Message-ID: <003d01cb9150$e0282690$a07873b0$%kim@samsung.com> (raw)
In-Reply-To: <20101201115535.GK24176@rakim.wolfsonmicro.main>
Mark Brown wrote:
>
> On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
>
> > > This makes all the functions that use the shift slightly smaller, one
> > > instruction in most cases but more for ack() and maskack().
>
> > Uhm...I'm not sure to use chip_data for the eint_irq_to_bit() is best to
us.
>
> Could you elaborate on your concern here? I can't think of anything
> else we might want to include in the data, and avoiding the shifts
> and/or dereferences seems useful for anyone doing interrupt heavy work.
Hehehe :-)
I just thought it again, I agree with you. Your patch looks ok to me...will
apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-12-01 12:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:18 [PATCH 1/3] ARM: SAMSUNG: Convert s3c_irqext_wake() to new irq_ interrupt methods Mark Brown
2010-11-25 15:18 ` [PATCH 2/3] ARM: S3C64XX: Convert S3C64xx irq-eint to use new irq_ methods Mark Brown
2010-12-01 11:30 ` Kukjin Kim
2010-11-25 15:18 ` [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs Mark Brown
2010-12-01 11:44 ` Kukjin Kim
2010-12-01 11:55 ` Mark Brown
2010-12-01 12:11 ` Kukjin Kim [this message]
2010-12-08 0:36 ` Ben Dooks
2010-12-01 10:19 ` [PATCH 1/3] ARM: SAMSUNG: Convert s3c_irqext_wake() to new irq_ interrupt methods Lennert Buytenhek
2010-12-01 11:08 ` Mark Brown
2010-12-01 11:45 ` Lennert Buytenhek
2010-12-01 11:47 ` Mark Brown
2010-12-01 11:24 ` Kukjin Kim
2010-12-01 11:28 ` Kukjin Kim
2010-12-01 11:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003d01cb9150$e0282690$a07873b0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox