From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: SAMSUNG: Convert s3c_irqext_wake() to new irq_ interrupt methods
Date: Wed, 1 Dec 2010 12:45:31 +0100 [thread overview]
Message-ID: <20101201114531.GK15575@mail.wantstofly.org> (raw)
In-Reply-To: <20101201110827.GB24176@rakim.wolfsonmicro.main>
On Wed, Dec 01, 2010 at 11:08:27AM +0000, Mark Brown wrote:
> > It would seem that this patch breaks s3c:
>
> > ./mach-s3c64xx/irq-eint.c: .irq_set_wake = s3c_irqext_wake,
> > ./plat-s3c24xx/irq.c: .irq_set_wake = s3c_irqext_wake
>
> Could you please elaborate on what you mean by "s3c" and why you think
> it has been broken?
My mistake, sorry -- I thought you had missed the two uses of
s3c_irqext_wake in ./mach-s3c64xx/irq-eint.c and ./plat-s3c24xx/irq.c,
but your patch does actually fix those up as well.
next prev parent reply other threads:[~2010-12-01 11:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:18 [PATCH 1/3] ARM: SAMSUNG: Convert s3c_irqext_wake() to new irq_ interrupt methods Mark Brown
2010-11-25 15:18 ` [PATCH 2/3] ARM: S3C64XX: Convert S3C64xx irq-eint to use new irq_ methods Mark Brown
2010-12-01 11:30 ` Kukjin Kim
2010-11-25 15:18 ` [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs Mark Brown
2010-12-01 11:44 ` Kukjin Kim
2010-12-01 11:55 ` Mark Brown
2010-12-01 12:11 ` Kukjin Kim
2010-12-08 0:36 ` Ben Dooks
2010-12-01 10:19 ` [PATCH 1/3] ARM: SAMSUNG: Convert s3c_irqext_wake() to new irq_ interrupt methods Lennert Buytenhek
2010-12-01 11:08 ` Mark Brown
2010-12-01 11:45 ` Lennert Buytenhek [this message]
2010-12-01 11:47 ` Mark Brown
2010-12-01 11:24 ` Kukjin Kim
2010-12-01 11:28 ` Kukjin Kim
2010-12-01 11:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201114531.GK15575@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox