From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
linux-samsung-soc@vger.kernel.org, tjakobi@math.uni-bielefeld.de,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v2 12/23] drm/exynos: don't track enabled state at exynos_crtc
Date: Thu, 9 Jul 2015 19:56:00 -0300 [thread overview]
Message-ID: <20150709225600.GA2000@joana> (raw)
In-Reply-To: <559E2C4C.9030603@samsung.com>
2015-07-09 Joonyoung Shim <jy0922.shim@samsung.com>:
> +Cc Andrzej,
>
> On 07/07/2015 02:41 AM, Daniel Vetter wrote:
> > On Mon, Jul 06, 2015 at 11:20:13AM -0300, Gustavo Padovan wrote:
> >> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >>
> >> struct drm_crtc already stores the enabled state of the crtc
> >> thus we don't need to replicate enabled in exynos_drm_crtc.
> >>
>
> I think exynos_crtc->enabled can replace flags for power state of each
> hw driver(e.g. "powered" of mixer driver, "suspended" of fimd driver).
> Further, we can add other flag bit for instead of using special flag
> in hw driver like vsync state("int_en" of mixer driver, "irq_flags" of
> fimd driver.)
The reason I removed it is because crtc->state->active already stores
the same information as exynos_crtc->enabled. I think we could rely
on active as well for mixer powered and suspended.
Gustavo
next prev parent reply other threads:[~2015-07-09 22:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 14:20 [PATCH v2 00/23] drm/exynos: atomic improvements + exynos_encoder removal Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 01/23] drm/exynos: pass the correct pipe number Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 02/23] drm/exynos: calculate vrefresh instead of use a fixed value Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 03/23] drm/exynos: use KMS version of DRM vblanks functions Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 04/23] drm/exynos: remove duplicated check for suspend Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 05/23] drm/exynos: add atomic asynchronous commit Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 06/23] drm/exynos: rename win_commit/disable to atomic-like names Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 07/23] drm/exynos: pass struct exynos_drm_plane in update/enable Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 08/23] drm/exynos: use drm atomic state directly Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 09/23] drm/exynos: remove unused fields from struct exynos_drm_plane Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 10/23] drm/exynos: unify exynos_drm_plane names with drm core Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 11/23] drm/exynos: return return value of exynos_crtc->enable_vblank Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 12/23] drm/exynos: don't track enabled state at exynos_crtc Gustavo Padovan
2015-07-06 17:41 ` Daniel Vetter
2015-07-09 8:09 ` Joonyoung Shim
2015-07-09 22:56 ` Gustavo Padovan [this message]
2015-07-10 0:47 ` Joonyoung Shim
2015-07-06 14:20 ` [PATCH v2 13/23] drm/exynos: split display's .dpms() into .enable() and .disable() Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 14/23] drm/exynos: remove wrappers for phy_power_{on,off} Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 15/23] drm/exynos: remove unused .remove() and .check_mode() ops from display Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 16/23] drm/exynos: simplify calculation of possible CRTCs Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 17/23] drm/exynos: remove struct exynos_drm_display Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 18/23] drm/exynos: remove extra call to hdmi_commit() Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 19/23] drm/exynos: remove extra call to exynos_dp_commit() Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 20/23] drm/exynos: remove exynos_encoder's .commit() op Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 21/23] drm/exynos: remove exynos_drm_create_enc_conn() Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 22/23] drm/exynos: fold encoder setup into exynos_drm_load() Gustavo Padovan
2015-07-06 14:20 ` [PATCH v2 23/23] drm/exynos: remove struct exynos_drm_encoder layer Gustavo Padovan
2015-07-14 7:34 ` [PATCH v2 00/23] drm/exynos: atomic improvements + exynos_encoder removal Joonyoung Shim
2015-07-16 15:26 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709225600.GA2000@joana \
--to=gustavo@padovan.org \
--cc=a.hajda@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox