Re: [PATCH v2 00/23] drm/exynos: atomic improvements + exynos_encoder removal

[Gustavo Padovan <gustavo@padovan.org>]

2015-07-14 Joonyoung Shim <jy0922.shim@samsung.com>:

> On 07/06/2015 11:20 PM, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > Hi,
> >
> > This set improves exynos in a number of ways. The first five patches are
> > general clean up/fixes.
> >
> > Patches 06 to 12 are improvements on top of the newly added atomic modesetting
> > support.
> >
> > Patches 13-23 are a big journey to completely remove the internal
> > exynos_drm_encoder struct. Now exynos encoders register themselves directly
> > with the drm core.
> 
> I got compile error with 13-23 patches.
> 
> drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function ‘exynos_dsi_bind’:
> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1839:3: error: ‘display’ undeclared (first use in this function)
>    display->encoder->bridge = bridge;
>    ^
> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1839:3: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_dsi.o] Error 1
> 
> 
> If you post the stuff that only be related, it will be reviewed and
> merged easier.
> 
> 01-04 and 06-11 patches look good to me, about them,
> Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>

Sure, I've resent only the patch with your Reviewed-by in a separate
patchset. The others will come in another patcheset.

	Gustavo