* [PATCH] crypto: s5p-sss: fix multiplatform build
@ 2014-05-09 11:35 Arnd Bergmann
2014-05-12 2:31 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2014-05-09 11:35 UTC (permalink / raw)
To: Herbert Xu
Cc: linux-crypto, David S. Miller, Naveen Krishna Chatradhi,
Tomasz Figa, linux-samsung-soc, Vladimir Zapolskiy
As we are preparing to enable multiplatform support on EXYNOS,
we can no longer include mach/*.h or plat/*.h headers from device
drivers.
The s5p-sss driver was just enabled for EXYNOS when it used to
be used only on s5pv210, and it includes two samsung platform
specific header files for historic reasons. Fortunately, it no
longer actually needs them, so we can remove the #includes and
avoid the problem
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: <linux-samsung-soc@vger.kernel.org>
Cc: Vladimir Zapolskiy <vz@mleia.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
Please apply on top of the other s5p-sss patches
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 47c568e..4197ad9 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -30,9 +30,6 @@
#include <crypto/aes.h>
#include <crypto/ctr.h>
-#include <plat/cpu.h>
-#include <mach/dma.h>
-
#define _SBF(s, v) ((v) << (s))
#define _BIT(b) _SBF(b, 1)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: s5p-sss: fix multiplatform build
2014-05-09 11:35 [PATCH] crypto: s5p-sss: fix multiplatform build Arnd Bergmann
@ 2014-05-12 2:31 ` Jingoo Han
2014-05-13 11:45 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-05-12 2:31 UTC (permalink / raw)
To: 'Arnd Bergmann', 'Herbert Xu'
Cc: linux-crypto, 'David S. Miller',
'Naveen Krishna Chatradhi', 'Tomasz Figa',
linux-samsung-soc, 'Vladimir Zapolskiy',
'Jingoo Han'
On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote:
>
> As we are preparing to enable multiplatform support on EXYNOS,
> we can no longer include mach/*.h or plat/*.h headers from device
> drivers.
>
> The s5p-sss driver was just enabled for EXYNOS when it used to
> be used only on s5pv210, and it includes two samsung platform
> specific header files for historic reasons. Fortunately, it no
> longer actually needs them, so we can remove the #includes and
> avoid the problem
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: <linux-samsung-soc@vger.kernel.org>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
I checked that these machine specific headers are
unnecessary. Thanks!
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> Please apply on top of the other s5p-sss patches
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 47c568e..4197ad9 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -30,9 +30,6 @@
> #include <crypto/aes.h>
> #include <crypto/ctr.h>
>
> -#include <plat/cpu.h>
> -#include <mach/dma.h>
> -
> #define _SBF(s, v) ((v) << (s))
> #define _BIT(b) _SBF(b, 1)
>
>
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: s5p-sss: fix multiplatform build
2014-05-12 2:31 ` Jingoo Han
@ 2014-05-13 11:45 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2014-05-13 11:45 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Arnd Bergmann', linux-crypto, 'David S. Miller',
'Naveen Krishna Chatradhi', 'Tomasz Figa',
linux-samsung-soc, 'Vladimir Zapolskiy'
On Mon, May 12, 2014 at 11:31:05AM +0900, Jingoo Han wrote:
> On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote:
> >
> > As we are preparing to enable multiplatform support on EXYNOS,
> > we can no longer include mach/*.h or plat/*.h headers from device
> > drivers.
> >
> > The s5p-sss driver was just enabled for EXYNOS when it used to
> > be used only on s5pv210, and it includes two samsung platform
> > specific header files for historic reasons. Fortunately, it no
> > longer actually needs them, so we can remove the #includes and
> > avoid the problem
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> > Cc: Tomasz Figa <t.figa@samsung.com>
> > Cc: <linux-samsung-soc@vger.kernel.org>
> > Cc: Vladimir Zapolskiy <vz@mleia.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
>
> I checked that these machine specific headers are
> unnecessary. Thanks!
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-09 11:35 [PATCH] crypto: s5p-sss: fix multiplatform build Arnd Bergmann
2014-05-12 2:31 ` Jingoo Han
2014-05-13 11:45 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox