Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Lukasz Majewski <l.majewski@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH RESEND 3/4] ARM: EXYNOS: Add s3c-hsotg device support for NURI board
Date: Sun, 13 May 2012 10:07:48 +0900	[thread overview]
Message-ID: <4FAF0964.9030704@samsung.com> (raw)
In-Reply-To: <1336655818-15136-4-git-send-email-l.majewski@samsung.com>

On 05/10/12 22:16, Lukasz Majewski wrote:
> From: Joonyoung Shim<jy0922.shim@samsung.com>
>
> This patch adds hsotg device to the NURI board.
>
> Signed-off-by: Joonyoung Shim<jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> [Rebased on the newest git/kgene/linux-samsung #for-next]
> Signed-off-by: Lukasz Majewski<l.majewski@samsung.com>
> ---
>   arch/arm/mach-exynos/Kconfig     |    1 +
>   arch/arm/mach-exynos/mach-nuri.c |    9 ++++++++-
>   2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 2c35fd4..5e64728 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -287,6 +287,7 @@ config MACH_NURI
>   	select S5P_DEV_MFC
>   	select S5P_DEV_USB_EHCI
>   	select S5P_SETUP_MIPIPHY
> +	select S3C_DEV_USB_HSOTG
>   	select EXYNOS4_DEV_DMA
>   	select EXYNOS4_SETUP_FIMC
>   	select EXYNOS4_SETUP_FIMD0
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 021dc68..4402aad 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -348,6 +348,7 @@ static struct regulator_consumer_supply __initdata max8997_ldo1_[] = {
>   	REGULATOR_SUPPLY("vdd", "s5p-adc"), /* Used by CPU's ADC drv */
>   };
>   static struct regulator_consumer_supply __initdata max8997_ldo3_[] = {
> +	REGULATOR_SUPPLY("vusb_d", "s3c-hsotg"), /* USB */
>   	REGULATOR_SUPPLY("vdd11", "s5p-mipi-csis.0"), /* MIPI */
>   };
>   static struct regulator_consumer_supply __initdata max8997_ldo4_[] = {
> @@ -363,7 +364,7 @@ static struct regulator_consumer_supply __initdata max8997_ldo7_[] = {
>   	REGULATOR_SUPPLY("dig_18", "0-001f"), /* HCD803 */
>   };
>   static struct regulator_consumer_supply __initdata max8997_ldo8_[] = {
> -	REGULATOR_SUPPLY("vusb_d", NULL), /* Used by CPU */
> +	REGULATOR_SUPPLY("vusb_a", "s3c-hsotg"), /* USB */
>   	REGULATOR_SUPPLY("vdac", NULL), /* Used by CPU */
>   };
>   static struct regulator_consumer_supply __initdata max8997_ldo11_[] = {
> @@ -819,6 +820,7 @@ static struct regulator_init_data __initdata max8997_esafeout1_data = {
>   	.constraints	= {
>   		.name		= "SAFEOUT1",
>   		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
> +		.always_on	= 1,
>   		.state_mem	= {
>   			.disabled	= 1,
>   		},
> @@ -1076,6 +1078,9 @@ static void __init nuri_ehci_init(void)
>   	s5p_ehci_set_platdata(pdata);
>   }
>
> +/* USB OTG */
> +static struct s3c_hsotg_plat nuri_hsotg_pdata;
> +
>   /* CAMERA */
>   static struct regulator_consumer_supply cam_vt_cam15_supply =
>   	REGULATOR_SUPPLY("vdd_core", "6-003c");
> @@ -1288,6 +1293,7 @@ static struct platform_device *nuri_devices[] __initdata = {
>   	&s5p_device_mfc_l,
>   	&s5p_device_mfc_r,
>   	&s5p_device_fimc_md,
> +	&s3c_device_usb_hsotg,
>
>   	/* NURI Devices */
>   	&nuri_gpio_keys,
> @@ -1336,6 +1342,7 @@ static void __init nuri_machine_init(void)
>   	nuri_camera_init();
>
>   	nuri_ehci_init();
> +	s3c_hsotg_set_platdata(&nuri_hsotg_pdata);
>
>   	/* Last */
>   	platform_add_devices(nuri_devices, ARRAY_SIZE(nuri_devices));

Oops, happens build error...

arch/arm/mach-s5pv210/mach-goni.c: In function 'goni_machine_init':
arch/arm/mach-s5pv210/mach-goni.c:947: error: implicit declaration of 
function 's3c_hsotg_set_platdata'

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2012-05-13  0:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 13:16 [PATCH RESEND 0/4] ARM: EXYNOS: Add s3c-hsotg support for Exynos4210 and S5PV210 boards Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 1/4] ARM: EXYNOS: Add usb otg phy control for EXYNOS4210 Lukasz Majewski
2012-05-16  8:17   ` Kukjin Kim
2012-05-16  9:36     ` Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 2/4] ARM: EXYNOS: Add s3c-hsotg device support for GONI board Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 3/4] ARM: EXYNOS: Add s3c-hsotg device support for NURI board Lukasz Majewski
2012-05-13  1:07   ` Kukjin Kim [this message]
2012-05-14  8:48     ` Lukasz Majewski
2012-05-14 14:01       ` Kukjin Kim
2012-05-10 13:16 ` [PATCH RESEND 4/4] ARM: EXYNOS: Add s3c-hsotg device support for Universal C210 board Lukasz Majewski
2012-05-12 23:53 ` [PATCH RESEND 0/4] ARM: EXYNOS: Add s3c-hsotg support for Exynos4210 and S5PV210 boards Kukjin Kim
2012-05-17  3:27 ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAF0964.9030704@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox