From: Kukjin Kim <kgene.kim@samsung.com>
To: Lukasz Majewski <l.majewski@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH RESEND 3/4] ARM: EXYNOS: Add s3c-hsotg device support for NURI board
Date: Mon, 14 May 2012 23:01:54 +0900 [thread overview]
Message-ID: <4FB11052.4090602@samsung.com> (raw)
In-Reply-To: <20120514104845.43ce9dea@lmajewski.digital.local>
On 05/14/12 17:48, Lukasz Majewski wrote:
> Hi Kukjin,
>
>> Oops, happens build error...
>>
>> arch/arm/mach-s5pv210/mach-goni.c: In function 'goni_machine_init':
>> arch/arm/mach-s5pv210/mach-goni.c:947: error: implicit declaration of
>> function 's3c_hsotg_set_platdata'
>
> Thanks for applying patches.
>
> Regarding the build error:
>
> After applying following patches on top of yours for next
> (linux-samsung/for-next) the problem with build error doesn't appear
> anymore.
>
Yes, I know why the build error happens and I can't apply them which are
already in usb tree in my tree now. I'm thinking this series should be
sent to upstream via usb tree together so if required, I will ask Greg
and Felipe to do it.
> Link to USB HSOTG patch series:
>
> http://permalink.gmane.org/gmane.linux.usb.general/62101
> "usb:hsotg:samsung USB S3C-HSOTG driver fixes and code cleanup"
>
> Moreover those patches have been already applied to Greg-KH's usb-next
> branch an will be released with 3.5 kernel.
>
Yeah, I know. But the problem is that if arm-soc tree is merged before
usb tree, same build error will be happened in mainline so I was
thinking how we can avoid that. If your effort is required, let you know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-05-14 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:16 [PATCH RESEND 0/4] ARM: EXYNOS: Add s3c-hsotg support for Exynos4210 and S5PV210 boards Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 1/4] ARM: EXYNOS: Add usb otg phy control for EXYNOS4210 Lukasz Majewski
2012-05-16 8:17 ` Kukjin Kim
2012-05-16 9:36 ` Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 2/4] ARM: EXYNOS: Add s3c-hsotg device support for GONI board Lukasz Majewski
2012-05-10 13:16 ` [PATCH RESEND 3/4] ARM: EXYNOS: Add s3c-hsotg device support for NURI board Lukasz Majewski
2012-05-13 1:07 ` Kukjin Kim
2012-05-14 8:48 ` Lukasz Majewski
2012-05-14 14:01 ` Kukjin Kim [this message]
2012-05-10 13:16 ` [PATCH RESEND 4/4] ARM: EXYNOS: Add s3c-hsotg device support for Universal C210 board Lukasz Majewski
2012-05-12 23:53 ` [PATCH RESEND 0/4] ARM: EXYNOS: Add s3c-hsotg support for Exynos4210 and S5PV210 boards Kukjin Kim
2012-05-17 3:27 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB11052.4090602@samsung.com \
--to=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox