Linux Samsung SOC development
 help / color / mirror / Atom feed
* [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used
@ 2010-10-05 23:30 Maurus Cuelenaere
  2011-04-02  2:23 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Maurus Cuelenaere @ 2010-10-05 23:30 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc; +Cc: ben-linux

s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs()
implementations, which get included through mach/pm-core.h. Add __maybe_unused
to silence warnings when it isn't used (e.g. on S3C64XX platforms).

Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
 arch/arm/plat-samsung/pm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c
index 27cfca5..ad6dd63 100644
--- a/arch/arm/plat-samsung/pm.c
+++ b/arch/arm/plat-samsung/pm.c
@@ -214,8 +214,9 @@ void s3c_pm_do_restore_core(struct sleep_save *ptr, int count)
  *
  * print any IRQs asserted at resume time (ie, we woke from)
 */
-static void s3c_pm_show_resume_irqs(int start, unsigned long which,
-				    unsigned long mask)
+static void __maybe_unused s3c_pm_show_resume_irqs(int start,
+						   unsigned long which,
+						   unsigned long mask)
 {
 	int i;
 
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used
  2010-10-05 23:30 [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used Maurus Cuelenaere
@ 2011-04-02  2:23 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2011-04-02  2:23 UTC (permalink / raw)
  To: 'Maurus Cuelenaere', linux-samsung-soc
  Cc: ben-linux, 'Abhilash Kesavan'

Maurus Cuelenaere wrote:
> 
> s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs()
> implementations, which get included through mach/pm-core.h. Add
> __maybe_unused
> to silence warnings when it isn't used (e.g. on S3C64XX platforms).
> 
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
>  arch/arm/plat-samsung/pm.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c
> index 27cfca5..ad6dd63 100644
> --- a/arch/arm/plat-samsung/pm.c
> +++ b/arch/arm/plat-samsung/pm.c
> @@ -214,8 +214,9 @@ void s3c_pm_do_restore_core(struct sleep_save *ptr,
int
> count)
>   *
>   * print any IRQs asserted at resume time (ie, we woke from)
>  */
> -static void s3c_pm_show_resume_irqs(int start, unsigned long which,
> -				    unsigned long mask)
> +static void __maybe_unused s3c_pm_show_resume_irqs(int start,
> +						   unsigned long which,
> +						   unsigned long mask)
>  {
>  	int i;
> 
> --

Missed for a long time :(

Abhilash, thanks for your reminder.

Ok, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-02  2:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 23:30 [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used Maurus Cuelenaere
2011-04-02  2:23 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox