Re: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

[Alexander Varnin <fenixk19@mail.ru>]

I also want to point, that irq resource in arch/arm/plat-samsung/devs.c 
for s3c2410-spi driver on S3C2443 points to wrong IRQ (SPI0 instead of 
SPI1). I've solved it with board specific code, but it is not most 
correct way, i think.

20.11.2012 15:46, Kukjin Kim пишет:
> Alexander Varnin wrote:
>> Actually, SPI channel 0 on 2443 is mapped to HS SPI controller,
>> and to enable s3c2410-spi controller, we should power on channel
>> 1 in PCLKCON. There is no channel 0 SPI on s3c2443, so delete its
>> clock.
>>
>> Signed-off-by: Alexander Varnin <fenixk19@mail.ru>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>   arch/arm/mach-s3c24xx/clock-s3c2443.c |    6 ------
>>   1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c24xx/clock-s3c2443.c
>> b/arch/arm/mach-s3c24xx/clock-s3c2443.c
>> index 7f689ce..bdaba59 100644
>> --- a/arch/arm/mach-s3c24xx/clock-s3c2443.c
>> +++ b/arch/arm/mach-s3c24xx/clock-s3c2443.c
>> @@ -158,12 +158,6 @@ static struct clk init_clocks_off[] = {
>>   		.devname	= "s3c2410-spi.0",
>>   		.parent		= &clk_p,
>>   		.enable		= s3c2443_clkcon_enable_p,
>> -		.ctrlbit	= S3C2443_PCLKCON_SPI0,
>> -	}, {
>> -		.name		= "spi",
>> -		.devname	= "s3c2410-spi.1",
>> -		.parent		= &clk_p,
>> -		.enable		= s3c2443_clkcon_enable_p,
>>   		.ctrlbit	= S3C2443_PCLKCON_SPI1,
>>   	}
>>   };
>> --
>> 1.7.2.5
> Applied, thanks.
>
> K-Gene <kgene@kernel.org>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html