From: Alexander Varnin <fenixk19@mail.ru>
To: Kukjin Kim <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed
Date: Thu, 22 Nov 2012 12:29:42 +0400 [thread overview]
Message-ID: <50ADE276.3030501@mail.ru> (raw)
In-Reply-To: <0f6d01cdc88a$8a0c5b00$9e251100$@org>
22.11.2012 12:22, Kukjin Kim пишет:
>> SPI1). I've solved it with board specific code, but it is not most
>> correct way, i think.
>>
> Hmm, if provided platform_device is in plat-samsung/devs.c cannot support, we can do as you said temporarily but we know it's wrong way because the value depends on SoC not board.
>
> How about following?
>
> 8<--------------------------------
> diff --git a/arch/arm/mach-s3c24xx/s3c2443.c b/arch/arm/mach-s3c24xx/s3c2443.c
> index 165b6a6..22eead3 100644
> --- a/arch/arm/mach-s3c24xx/s3c2443.c
> +++ b/arch/arm/mach-s3c24xx/s3c2443.c
> @@ -82,6 +82,10 @@ int __init s3c2443_init(void)
> s3c_device_wdt.resource[1].start = IRQ_S3C2443_WDT;
> s3c_device_wdt.resource[1].end = IRQ_S3C2443_WDT;
>
> + /* change SPI IRQ number */
> + s3c_device_spi0.resource[1].start = IRQ_SPI1;
> + s3c_device_spi0.resource[1].end = IRQ_SPI1;
> +
> return device_register(&s3c2443_dev);
> }
> 8<--------------------------------
>
> K-Gene <kgene@kernel.org>
>
Yes, that is a fix. Thanks.
next prev parent reply other threads:[~2012-11-22 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 21:55 [PATCH] ARM: S3C2443: SPI clock channel setup is fixed Alexander Varnin
2012-11-20 11:46 ` Kukjin Kim
2012-11-22 7:57 ` Alexander Varnin
2012-11-22 8:22 ` Kukjin Kim
2012-11-22 8:29 ` Alexander Varnin [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-19 14:33 Alexander Varnin
2012-11-19 21:32 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ADE276.3030501@mail.ru \
--to=fenixk19@mail.ru \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox