Linux Samsung SOC development
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node
@ 2014-12-19  8:39 Beomho Seo
  2014-12-19  8:39 ` [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys Beomho Seo
  2014-12-19  8:41 ` [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Chanwoo Choi
  0 siblings, 2 replies; 4+ messages in thread
From: Beomho Seo @ 2014-12-19  8:39 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree
  Cc: kgene.kim, yj44.cho, cw00.choi, inki.dae, sw0312.kim, jh80.chung,
	kyungmin.park, beomho.seo

This patch remove unecessary property of gpio-keys node.
gpio-keys driver do not uses interrupts and interrupt-parent.

Cc: Youngjun Cho <yj44.cho@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
 arch/arm/boot/dts/exynos3250-monk.dts   |    2 --
 arch/arm/boot/dts/exynos3250-rinato.dts |    2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 24822aa..2129ab98 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -37,8 +37,6 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			interrupt-parent = <&gpx2>;
-			interrupts = <7 0>;
 			gpios = <&gpx2 7 1>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 80aa8b4..c186ac6 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -37,8 +37,6 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			interrupt-parent = <&gpx2>;
-			interrupts = <7 0>;
 			gpios = <&gpx2 7 1>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys
  2014-12-19  8:39 [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Beomho Seo
@ 2014-12-19  8:39 ` Beomho Seo
  2014-12-19  8:41   ` Chanwoo Choi
  2014-12-19  8:41 ` [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Chanwoo Choi
  1 sibling, 1 reply; 4+ messages in thread
From: Beomho Seo @ 2014-12-19  8:39 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree
  Cc: kgene.kim, yj44.cho, cw00.choi, inki.dae, sw0312.kim, jh80.chung,
	kyungmin.park, beomho.seo

This patch replace number by macro in gpio keys for exynos 3250 boards.

Cc: Youngjun Cho <yj44.cho@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
 arch/arm/boot/dts/exynos3250-monk.dts   |    3 ++-
 arch/arm/boot/dts/exynos3250-rinato.dts |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 2129ab98..792a2c7 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -15,6 +15,7 @@
 /dts-v1/;
 #include "exynos3250.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Samsung Monk board";
@@ -37,7 +38,7 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			gpios = <&gpx2 7 1>;
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
 			debounce-interval = <10>;
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index c186ac6..3493bca 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -15,6 +15,7 @@
 /dts-v1/;
 #include "exynos3250.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Samsung Rinato board";
@@ -37,7 +38,7 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			gpios = <&gpx2 7 1>;
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
 			debounce-interval = <10>;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node
  2014-12-19  8:39 [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Beomho Seo
  2014-12-19  8:39 ` [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys Beomho Seo
@ 2014-12-19  8:41 ` Chanwoo Choi
  1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2014-12-19  8:41 UTC (permalink / raw)
  To: Beomho Seo
  Cc: linux-samsung-soc, devicetree, kgene.kim, yj44.cho, inki.dae,
	sw0312.kim, jh80.chung, kyungmin.park

Hi Beomho,

On 12/19/2014 05:39 PM, Beomho Seo wrote:
> This patch remove unecessary property of gpio-keys node.
> gpio-keys driver do not uses interrupts and interrupt-parent.
> 
> Cc: Youngjun Cho <yj44.cho@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo CHoi

> ---
>  arch/arm/boot/dts/exynos3250-monk.dts   |    2 --
>  arch/arm/boot/dts/exynos3250-rinato.dts |    2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
> index 24822aa..2129ab98 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -37,8 +37,6 @@
>  		compatible = "gpio-keys";
>  
>  		power_key {
> -			interrupt-parent = <&gpx2>;
> -			interrupts = <7 0>;
>  			gpios = <&gpx2 7 1>;
>  			linux,code = <KEY_POWER>;
>  			label = "power key";
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 80aa8b4..c186ac6 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -37,8 +37,6 @@
>  		compatible = "gpio-keys";
>  
>  		power_key {
> -			interrupt-parent = <&gpx2>;
> -			interrupts = <7 0>;
>  			gpios = <&gpx2 7 1>;
>  			linux,code = <KEY_POWER>;
>  			label = "power key";
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys
  2014-12-19  8:39 ` [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys Beomho Seo
@ 2014-12-19  8:41   ` Chanwoo Choi
  0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2014-12-19  8:41 UTC (permalink / raw)
  To: Beomho Seo
  Cc: linux-samsung-soc, devicetree, kgene.kim, yj44.cho, inki.dae,
	sw0312.kim, jh80.chung, kyungmin.park

Hi Beomho,

On 12/19/2014 05:39 PM, Beomho Seo wrote:
> This patch replace number by macro in gpio keys for exynos 3250 boards.
> 
> Cc: Youngjun Cho <yj44.cho@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo CHoi

> ---
>  arch/arm/boot/dts/exynos3250-monk.dts   |    3 ++-
>  arch/arm/boot/dts/exynos3250-rinato.dts |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
> index 2129ab98..792a2c7 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -15,6 +15,7 @@
>  /dts-v1/;
>  #include "exynos3250.dtsi"
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	model = "Samsung Monk board";
> @@ -37,7 +38,7 @@
>  		compatible = "gpio-keys";
>  
>  		power_key {
> -			gpios = <&gpx2 7 1>;
> +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
>  			linux,code = <KEY_POWER>;
>  			label = "power key";
>  			debounce-interval = <10>;
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index c186ac6..3493bca 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -15,6 +15,7 @@
>  /dts-v1/;
>  #include "exynos3250.dtsi"
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	model = "Samsung Rinato board";
> @@ -37,7 +38,7 @@
>  		compatible = "gpio-keys";
>  
>  		power_key {
> -			gpios = <&gpx2 7 1>;
> +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
>  			linux,code = <KEY_POWER>;
>  			label = "power key";
>  			debounce-interval = <10>;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-19  8:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19  8:39 [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Beomho Seo
2014-12-19  8:39 ` [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys Beomho Seo
2014-12-19  8:41   ` Chanwoo Choi
2014-12-19  8:41 ` [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox