Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
To: "Bart Van Assche" <bvanassche@acm.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "ebiggers@google.com" <ebiggers@google.com>,
	"ahalaney@redhat.com" <ahalaney@redhat.com>,
	"quic_mnaresh@quicinc.com" <quic_mnaresh@quicinc.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"manivannan.sadhasivam@linaro.org"
	<manivannan.sadhasivam@linaro.org>,
	"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation
Date: Tue, 27 Aug 2024 14:59:19 -0700	[thread overview]
Message-ID: <03bfe9e7-c2cb-d703-9d0b-7b322ea434a1@quicinc.com> (raw)
In-Reply-To: <f7f0ca00-a8ce-4841-8483-5ad886da82ad@acm.org>

On 8/27/2024 8:42 AM, Bart Van Assche wrote:
> On 8/26/24 6:39 PM, Peter Wang (王信友) wrote:
>> It is not a new vendor hook, ufshcd_vops_hibern8_notify is exist
>> in current kernel.
> Hi Peter,
> 
> Is something like the untested patch below perhaps what you have in
> mind?

Hi Bart, IMHO even though the patch may work, it makes the existing code 
more complicated with the disable_uic_compl_intr flag being sent to the 
platform driver that has nothing to do with it. It seems the proposal 
makes the code harder to read as well. A new person without any history 
of this issue trying to understand the purpose of this flag would 
probably need to spend some extra time digging the history.

Thanks, Bao

  reply	other threads:[~2024-08-27 21:59 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 18:29 [PATCH 0/2] Fix the UFS driver hibernation code Bart Van Assche
2024-08-21 18:29 ` [PATCH 1/2] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to read Bart Van Assche
2024-08-21 21:27   ` Bean Huo
2024-08-22  5:34   ` Peter Wang (王信友)
2024-08-22 17:02     ` Bart Van Assche
2024-08-23  2:54       ` Peter Wang (王信友)
2024-08-26  6:25   ` Dan Carpenter
2024-08-26 18:05     ` Bart Van Assche
2024-08-26 21:36       ` Dan Carpenter
2024-08-21 18:29 ` [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation Bart Van Assche
2024-08-21 21:27   ` Bean Huo
2024-08-21 21:39     ` Bart Van Assche
2024-08-22 14:17       ` Bean Huo
2024-08-22 17:51         ` Bart Van Assche
2024-08-23 10:54           ` Bean Huo
2024-08-23 11:26             ` Can Guo
2024-08-23 16:09             ` Bart Van Assche
2024-08-21 23:26   ` Bao D. Nguyen
2024-08-22  0:14     ` Bart Van Assche
2024-08-22  1:05       ` Bao D. Nguyen
2024-08-22 18:13         ` Bart Van Assche
2024-08-22 20:54           ` Bao D. Nguyen
2024-08-22 21:08             ` Bart Van Assche
2024-08-23 12:01               ` Manivannan Sadhasivam
2024-08-23 14:23                 ` Bart Van Assche
2024-08-23 14:58                   ` Manivannan Sadhasivam
2024-08-23 16:07                     ` Bart Van Assche
2024-08-23 16:48                       ` Manivannan Sadhasivam
2024-08-23 18:05                         ` Bart Van Assche
2024-08-24  2:29                           ` Manivannan Sadhasivam
2024-08-24  2:48                             ` Bart Van Assche
2024-08-24  3:03                               ` Manivannan Sadhasivam
2024-08-26  6:48                                 ` Can Guo
2024-08-22  6:36       ` [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation Manivannan Sadhasivam
2024-08-22  5:36   ` Peter Wang (王信友)
2024-08-22 23:34   ` Bao D. Nguyen
2024-08-23  2:06     ` Bart Van Assche
2024-08-23  2:57       ` Peter Wang (王信友)
2024-08-23 20:27         ` Bart Van Assche
2024-08-26  6:16           ` Peter Wang (王信友)
2024-08-26 18:08             ` Bart Van Assche
2024-08-27  1:39               ` Peter Wang (王信友)
2024-08-27 15:42                 ` Bart Van Assche
2024-08-27 21:59                   ` Bao D. Nguyen [this message]
2024-08-28  6:17                   ` Peter Wang (王信友)
2024-08-28 11:18                     ` Bart Van Assche
2024-08-28 13:46                       ` Peter Wang (王信友)
2024-08-28 14:10                         ` Bart Van Assche
2024-08-29  2:34                           ` Peter Wang (王信友)
2024-08-23  3:43       ` Bao D. Nguyen
2024-08-23 20:25         ` Bart Van Assche
2024-08-27 21:17           ` Bao D. Nguyen
2024-08-27 21:39             ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03bfe9e7-c2cb-d703-9d0b-7b322ea434a1@quicinc.com \
    --to=quic_nguyenb@quicinc.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ahalaney@redhat.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=ebiggers@google.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=minwoo.im@samsung.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_mnaresh@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox