Re: [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Mon, 2024-08-26 at 11:08 -0700, Bart Van Assche wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 8/25/24 11:16 PM, Peter Wang (王信友) wrote:
> > In this case, I suggest use a vendor hooks
> ufshcd_vops_hibern8_notify.
> > When hibernate enter pre-change, disable UIC_COMMAND_COMPL
> interrupt
> > to prevent enable UIC_COMMAND_COMPL after hibernate enter.
> > When hibernate exit post-change, enable UIC_COMMAND_COMPL
> interrupt.
> > 
> > If it works, it won't modify the native kernel code, nor will it
> > require adding a quirk. It would simply use a vendor hook as a
> > workaround, without violating GKI, right?
> 
> Hmm ... does this mean introducing a new vendor hook without
> introducing
> any host driver code that implements that hook? I don't think this is
> allowed.
> 

Hi Bart,

It is not a new vendor hook, ufshcd_vops_hibern8_notify is exist 
in current kernel.

Thanks.
Peter


> How about introducing a quirk that selects the current behavior if
> set
> (disable UIC completion interrupt around hibernation) and not
> touching
> the UIC completion interrupt if that quirk is not set?
> 
> Thanks,
> 
> Bart.