Re: [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Wed, 2024-08-21 at 11:29 -0700, Bart Van Assche wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Accessing a host controller register after the host controller has
> entered the hibernation state may cause the host controller to exit
> the
> hibernation state. Hence rework the hibernation entry code such that
> it
> does not modify the interrupt enabled status. This patch relies on
> the
> following:
> * If an UIC command is submitted that should be completed by the UIC
>   command completion interrupt, hba->uic_async_done == NULL.
> * If an UIC command is submitted that should be completed by the
> power
>   mode change interrupt or by a hibernation state change interrupt,
>   hba->uic_async_done != NULL.
> 
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> 

Hi Bart,

If link enter hibernate, change power mode should wakeup link 
to active before power mode change.
So, even manual hibernate exit by clock ungating or auto 
hiberante exit by hardware, write hci interrupt register exit 
hiberante should not a problem?

Thanks.
Peter