From: Pat LaVarre <p.lavarre@ieee.org>
To: axboe@suse.de
Cc: linux-scsi@vger.kernel.org
Subject: Re: writable mmc profiles actually are writable
Date: 06 Oct 2003 14:10:47 -0600 [thread overview]
Message-ID: <1065471047.5185.48.camel@patehci2> (raw)
In-Reply-To: <20031006182223.GF972@suse.de>
> > +// if ((fp->f_mode & FMODE_WRITE) && !CDROM_CAN(CDC_DVD_RAM))
> > +// return -EROFS;
> > +// if (!cd->device->writeable)
> > +// return 0;
>
> ... obviously wrong
May I ask why this patch is obviously wrong?
What actually breaks?
How do we benefit from having cdrom.ko and sr_mod.ko redundantly refuse
writes?
I figure I should try mount of a cd-rom with this patch. Maybe I get
mount -w when I wanted mount -r and then life goes downhill from there.
Or maybe iso fs doesn't try to write. Or ...
Pat LaVarre
next prev parent reply other threads:[~2003-10-06 20:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 22:55 [linux-usb-devel] Re: USB storage problems on OHCI Pat LaVarre
2003-09-29 14:54 ` Pat LaVarre
2003-09-29 15:50 ` 2 KiB/block loopback found where Pat LaVarre
2003-09-29 16:46 ` Jens Axboe
2003-09-29 17:12 ` Pat LaVarre
2003-09-29 20:02 ` Pat LaVarre
2003-10-06 17:12 ` max GiB written per boot Pat LaVarre
2003-10-06 18:12 ` writable mmc profiles actually are writable Pat LaVarre
2003-10-06 18:22 ` Jens Axboe
2003-10-06 18:25 ` Jens Axboe
2003-10-06 19:50 ` Pat LaVarre
2003-10-06 20:38 ` Jens Axboe
2003-10-06 20:58 ` Pat LaVarre
2003-10-06 22:14 ` Pat LaVarre
2003-10-06 23:56 ` Pat LaVarre
2003-10-07 5:38 ` Jens Axboe
2003-10-07 6:45 ` Matthew Dharm
2003-10-07 6:48 ` Jens Axboe
2003-10-07 7:00 ` Matthew Dharm
2003-10-07 7:04 ` Jens Axboe
2003-10-10 20:36 ` Pat LaVarre
2003-10-10 21:04 ` Pat LaVarre
2003-10-10 21:25 ` Pat LaVarre
2003-10-10 22:43 ` Pat LaVarre
2003-10-10 23:16 ` Pat LaVarre
2003-10-11 0:43 ` Pat LaVarre
2003-10-07 20:46 ` Pat LaVarre
2003-10-07 21:00 ` Jens Axboe
2003-10-09 23:01 ` Pat LaVarre
2003-10-07 7:00 ` Jens Axboe
2003-10-06 20:10 ` Pat LaVarre [this message]
2003-10-06 20:28 ` Jens Axboe
2003-10-06 20:21 ` Pat LaVarre
2003-10-06 20:33 ` Jens Axboe
2003-10-06 21:00 ` max GiB written per boot Pat LaVarre
2003-10-06 23:47 ` Pat LaVarre
2003-10-07 5:57 ` Jens Axboe
2003-10-07 22:12 ` Randy.Dunlap
2003-10-07 22:57 ` Willem Riede
2003-10-08 1:27 ` Randy.Dunlap
2003-10-08 4:34 ` Randy.Dunlap
2003-10-08 6:44 ` Jens Axboe
2003-10-09 21:59 ` Pat LaVarre
2003-10-10 20:54 ` Pat LaVarre
2003-10-07 0:51 ` 2 KiB/block loopback found where Pat LaVarre
2003-09-29 17:55 ` aligned /dev/scd$n reads less rare how Pat LaVarre
2003-09-29 19:39 ` zip of GiB cross-platform Pat LaVarre
2003-09-29 19:50 ` Matthew Wilcox
2003-09-29 19:56 ` Pat LaVarre
2003-10-24 14:41 ` aligned /dev/scd$n reads less rare how Pat LaVarre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065471047.5185.48.camel@patehci2 \
--to=p.lavarre@ieee.org \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox