* [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems
@ 2005-08-15 21:22 mikem
2005-08-15 21:32 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: mikem @ 2005-08-15 21:22 UTC (permalink / raw)
To: marcelo.tosatti, axboe; +Cc: linux-kernel, linux-scsi
Patch 3/4
This patch adds 2 ioctls required for IPF systems. Without this change
parted may fail. This causes some vendor installs to fail.
Please consider this for inclusion.
Signed-off-by: Mike Miller <mike.miller@hp.com>
cciss.c | 5 +++++
1 files changed, 5 insertions(+)
--------------------------------------------------------------------------------
diff -burNp lx2431-p002/drivers/block/cciss.c lx2431/drivers/block/cciss.c
--- lx2431-p002/drivers/block/cciss.c 2005-08-15 15:13:15.484004000 -0500
+++ lx2431/drivers/block/cciss.c 2005-08-15 15:18:32.863755640 -0500
@@ -748,7 +748,12 @@ static int cciss_ioctl(struct inode *ino
case BLKELVGET:
case BLKELVSET:
case BLKSSZGET:
+#ifdef CONFIG_IA64
+ case BLKGETLASTSECT:
+ case BLKSETLASTSECT:
+#endif
return blk_ioctl(inode->i_rdev, cmd, arg);
+
case CCISS_GETPCIINFO:
{
cciss_pci_info_struct pciinfo;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems
2005-08-15 21:22 [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems mikem
@ 2005-08-15 21:32 ` James Bottomley
2005-08-15 21:49 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2005-08-15 21:32 UTC (permalink / raw)
To: mikem; +Cc: marcelo.tosatti, Jens Axboe, Linux Kernel, SCSI Mailing List
On Mon, 2005-08-15 at 16:22 -0500, mikem wrote:
> +#ifdef CONFIG_IA64
> + case BLKGETLASTSECT:
> + case BLKSETLASTSECT:
> +#endif
> return blk_ioctl(inode->i_rdev, cmd, arg);
What makes these two ioctls IA64 specific? I think they're completely
general in 2.4, so there's no need for the #ifdef.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems
2005-08-15 21:32 ` James Bottomley
@ 2005-08-15 21:49 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-08-15 21:49 UTC (permalink / raw)
To: James Bottomley
Cc: mikem, marcelo.tosatti, Jens Axboe, Linux Kernel,
SCSI Mailing List
On Mon, Aug 15, 2005 at 04:32:53PM -0500, James Bottomley wrote:
> On Mon, 2005-08-15 at 16:22 -0500, mikem wrote:
> > +#ifdef CONFIG_IA64
> > + case BLKGETLASTSECT:
> > + case BLKSETLASTSECT:
> > +#endif
> > return blk_ioctl(inode->i_rdev, cmd, arg);
>
> What makes these two ioctls IA64 specific? I think they're completely
> general in 2.4, so there's no need for the #ifdef.
They don't exist in 2.4 mainline. The ia64 patch and then many
distributions introduced it because the EFI partitions spec contains
some braindamage that requries accessing the last sector. In 2.6 the
block device nodes can do that, so the ioctls aren't needed either.
In short this patch should not go into mainline 2.4, it doesn't support
ia64 anyway and if it did it wouldn't compile because the ioctls aren't
defined.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-15 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-15 21:22 [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems mikem
2005-08-15 21:32 ` James Bottomley
2005-08-15 21:49 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox