Pending patches

Pending patches

[Alan Stern]

James:

May I draw your attention to these patch submissions:

http://marc.theaimsgroup.com/?l=linux-scsi&m=111221335824727&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112117962214214&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238708903663&w=2 (this 
	is a cover message, not a patch)
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238726326927&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238753725214&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238771326644&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238804301664&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=112238825727146&w=2

I never received any word back after submitting them, and they aren't 
present in the source tree at

http://www.parisc-linux.org/cgi-bin/gitweb.pl

Is it possible to get these patches into the queue?

Alan Stern

Re: Pending patches

[Patrick Mansfield]

On Tue, Sep 06, 2005 at 04:17:53PM -0400, Alan Stern wrote:

> I never received any word back after submitting them, and they aren't 
> present in the source tree at
> 
> http://www.parisc-linux.org/cgi-bin/gitweb.pl
> 
> Is it possible to get these patches into the queue?

Not that your patches are in it, but the scsi-misc tre is at:

http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=summary

-- Patrick Mansfield

Re: Pending patches

[Alan Stern]

On Tue, 6 Sep 2005, Patrick Mansfield wrote:

> On Tue, Sep 06, 2005 at 04:17:53PM -0400, Alan Stern wrote:
> 
> > I never received any word back after submitting them, and they aren't 
> > present in the source tree at
> > 
> > http://www.parisc-linux.org/cgi-bin/gitweb.pl
> > 
> > Is it possible to get these patches into the queue?
> 
> Not that your patches are in it, but the scsi-misc tre is at:
> 
> http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=summary

Thanks for the pointer.  James's earlier message didn't make it clear
whether the browser he mentioned was for the scsi-rc-fixes tree or the
scsi-misc tree.  Nor was it clear which patches one should expect to find 
in those two trees; I assume that patches go first into the scsi-misc 
tree, then eventually migrate to the scsi-rc-fixes tree, and hence to 
Linus.  Is that right?

Alan Stern

Re: Pending patches

[James Bottomley]

On Tue, 2005-09-06 at 16:17 -0400, Alan Stern wrote:
> May I draw your attention to these patch submissions:
> 
> http://marc.theaimsgroup.com/?l=linux-scsi&m=111221335824727&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112117962214214&w=2

These two should be in.

> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238708903663&w=2 (this 
> 	is a cover message, not a patch)
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238726326927&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238753725214&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238771326644&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238804301664&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112238825727146&w=2

I was hoping that Mike Anderson would review these, but since he hasn't
I'll take a look.

James

Re: Pending patches

[Mike Anderson]

James Bottomley <James.Bottomley@SteelEye.com> wrote:
> On Tue, 2005-09-06 at 16:17 -0400, Alan Stern wrote:
> > http://marc.theaimsgroup.com/?l=linux-scsi&m=112238726326927&w=2

On as542. The first hunk of the diff is already in (declare of
scsi_host_set_state). The second hunk looks good (SHOST_RECOVERY label).
The third hunk I will take in combination with the other patch that
effects the scan code. This should have probably been
another patch.

> > http://marc.theaimsgroup.com/?l=linux-scsi&m=112238771326644&w=2

Have not looked at this yet, but will look at it in combination to the
above scan change.

> > http://marc.theaimsgroup.com/?l=linux-scsi&m=112238804301664&w=2

Do we need to revist how we are walking these lists for cleanup post
James's kilst fix / update?

> > http://marc.theaimsgroup.com/?l=linux-scsi&m=112238825727146&w=2

This looks ok for an added check, but I guess I need to look at old mail
and understand how we got here with the added scan mutex.

> 
> I was hoping that Mike Anderson would review these, but since he hasn't
> I'll take a look.

Sorry asleep at the keyboard on these. Comments above if you have not
already looked at them.

-andmike
--
Michael Anderson
andmike@us.ibm.com

Pending patches

[Alan Stern]

James:

The patches below have been pending for quite a while:

	http://marc.info/?l=linux-scsi&m=122814525009429&w=2
	http://marc.info/?l=linux-scsi&m=122935526508941&w=2

I expected to see them already in 2.6.29-rc1.  They certainly should be 
merged sometime during the 2.6.29 time frame.

Alan Stern

Pending patches

[Alan Stern]

James:

Whatever happened to the 6-part patch series I submitted at the end of 
May?

0/6:	http://marc.info/?l=linux-scsi&m=124388632706196&w=2
1/6:	http://marc.info/?l=linux-scsi&m=124388639906873&w=2
2/6:	http://marc.info/?l=linux-scsi&m=124388664609269&w=2
3/6:	http://marc.info/?l=linux-scsi&m=124388664009217&w=2
4/6:	http://marc.info/?l=linux-scsi&m=124388742715268&w=2
5/6:	http://marc.info/?l=linux-scsi&m=124388752015618&w=2
6/6v2:	http://marc.info/?l=linux-scsi&m=124404339912876&w=2

Is there any reason they haven't gotten into scsi-misc for the next 
merge window?  It has been six weeks...

Alan Stern

Re: Pending patches

[James Bottomley]

On Wed, 2009-07-15 at 14:01 -0400, Alan Stern wrote:
> James:
> 
> Whatever happened to the 6-part patch series I submitted at the end of 
> May?
> 
> 0/6:	http://marc.info/?l=linux-scsi&m=124388632706196&w=2
> 1/6:	http://marc.info/?l=linux-scsi&m=124388639906873&w=2
> 2/6:	http://marc.info/?l=linux-scsi&m=124388664609269&w=2
> 3/6:	http://marc.info/?l=linux-scsi&m=124388664009217&w=2
> 4/6:	http://marc.info/?l=linux-scsi&m=124388742715268&w=2
> 5/6:	http://marc.info/?l=linux-scsi&m=124388752015618&w=2
> 6/6v2:	http://marc.info/?l=linux-scsi&m=124404339912876&w=2
> 
> Is there any reason they haven't gotten into scsi-misc for the next 
> merge window?  It has been six weeks...

According to the thread, there's no confirmation from the reporter that
they actually fix the problem.

James

Re: Pending patches

[Alan Stern]

On Thu, 16 Jul 2009, James Bottomley wrote:

> On Wed, 2009-07-15 at 14:01 -0400, Alan Stern wrote:
> > James:
> > 
> > Whatever happened to the 6-part patch series I submitted at the end of 
> > May?
> > 
> > 0/6:	http://marc.info/?l=linux-scsi&m=124388632706196&w=2
> > 1/6:	http://marc.info/?l=linux-scsi&m=124388639906873&w=2
> > 2/6:	http://marc.info/?l=linux-scsi&m=124388664609269&w=2
> > 3/6:	http://marc.info/?l=linux-scsi&m=124388664009217&w=2
> > 4/6:	http://marc.info/?l=linux-scsi&m=124388742715268&w=2
> > 5/6:	http://marc.info/?l=linux-scsi&m=124388752015618&w=2
> > 6/6v2:	http://marc.info/?l=linux-scsi&m=124404339912876&w=2
> > 
> > Is there any reason they haven't gotten into scsi-misc for the next 
> > merge window?  It has been six weeks...
> 
> According to the thread, there's no confirmation from the reporter that
> they actually fix the problem.

Please reconsider them not as specific bug fixes but rather as general
cleanups and improvements.  I.e., the sort of thing one would not send
to Linus until the next merge window.

Alan Stern

Re: Pending patches

[Alan Stern]

On Thu, 16 Jul 2009, Alan Stern wrote:

> On Thu, 16 Jul 2009, James Bottomley wrote:
> 
> > On Wed, 2009-07-15 at 14:01 -0400, Alan Stern wrote:
> > > James:
> > > 
> > > Whatever happened to the 6-part patch series I submitted at the end of 
> > > May?
> > > 
> > > 0/6:	http://marc.info/?l=linux-scsi&m=124388632706196&w=2
> > > 1/6:	http://marc.info/?l=linux-scsi&m=124388639906873&w=2
> > > 2/6:	http://marc.info/?l=linux-scsi&m=124388664609269&w=2
> > > 3/6:	http://marc.info/?l=linux-scsi&m=124388664009217&w=2
> > > 4/6:	http://marc.info/?l=linux-scsi&m=124388742715268&w=2
> > > 5/6:	http://marc.info/?l=linux-scsi&m=124388752015618&w=2
> > > 6/6v2:	http://marc.info/?l=linux-scsi&m=124404339912876&w=2
> > > 
> > > Is there any reason they haven't gotten into scsi-misc for the next 
> > > merge window?  It has been six weeks...
> > 
> > According to the thread, there's no confirmation from the reporter that
> > they actually fix the problem.
> 
> Please reconsider them not as specific bug fixes but rather as general
> cleanups and improvements.  I.e., the sort of thing one would not send
> to Linus until the next merge window.

James, I haven't heard anything back about this.  It's very 
discouraging to submit serious patches only to have them ignored for 
two months.

Would it help if I rewrote the changelogs?  Is there anything else I 
can do to bring these into consideration?

Alan Stern

Pending patches

[Alan Stern]

James:

Have you had any time to review these three bug-fix patches?

	http://marc.info/?l=linux-scsi&m=126894117503693&w=2
	http://marc.info/?l=linux-scsi&m=126894127403891&w=2
	http://marc.info/?l=linux-scsi&m=126894128403918&w=2

Each one is quite short, and it should be easy to verify that they 
really do what they claim.

Alan Stern