media change events for polled devices broken with current sdev_evt_send()

media change events for polled devices broken with current sdev_evt_send()

[Kay Sievers]

Hi Jeff,
  a341cd0f (SCSI: add asynchronous event notification API)
introduces an event filter like:
  +       if (!test_bit(evt->evt_type, sdev->supported_events)) {
  +               kfree(evt);
  +               return;
  +       }

which breaks:
  285e9670 (sr,sd: send media state change modification events)

Why are events sent through sdev_evt_send() filtered? In which case does
code send an event which we don't want to deliver?


Side note: introduced with a341cd0f is the sysfs file:
"evt_media_change", which has a store() method, but has the permission
0444. It should either have no store() method assigned, by introducing
something like DECLARE_EVT_RO(), or the file permission should be
changed to 0644.

Thanks,
Kay

Re: media change events for polled devices broken with current sdev_evt_send()

[Kay Sievers]

Ping! Jeff, please answer the question. We need the media change events
for non AN devices.

Thanks,
Kay

On Thu, 2008-03-06 at 10:29 +0100, Kay Sievers wrote:
> Hi Jeff,
>   a341cd0f (SCSI: add asynchronous event notification API)
> introduces an event filter like:
>   +       if (!test_bit(evt->evt_type, sdev->supported_events)) {
>   +               kfree(evt);
>   +               return;
>   +       }
> 
> which breaks:
>   285e9670 (sr,sd: send media state change modification events)
> 
> Why are events sent through sdev_evt_send() filtered? In which case does
> code send an event which we don't want to deliver?
> 
> 
> Side note: introduced with a341cd0f is the sysfs file:
> "evt_media_change", which has a store() method, but has the permission
> 0444. It should either have no store() method assigned, by introducing
> something like DECLARE_EVT_RO(), or the file permission should be
> changed to 0644.
> 
> Thanks,
> Kay