* Re: [PATCH] [AACRAID] Do not describe check_reset parameter with its value [not found] <1208334879.5614.34.camel@compaq.thuisdomein> @ 2008-04-16 12:29 ` Mark Salyzyn 2008-04-16 12:43 ` Paul Bolle 0 siblings, 1 reply; 3+ messages in thread From: Mark Salyzyn @ 2008-04-16 12:29 UTC (permalink / raw) To: Paul Bolle, Linux-Scsi ACK On Apr 16, 2008, at 4:34 AM, Paul Bolle wrote: From: Paul Bolle <pebolle@tiscali.nl> Describe check_reset parameter with its name (and not its value) Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/ aachba.c index c05092f..43c7890 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -205,7 +205,7 @@ MODULE_PARM_DESC(check_interval, "Interval in seconds between adapter health" int aac_check_reset = 1; module_param_named(check_reset, aac_check_reset, int, S_IRUGO|S_IWUSR); -MODULE_PARM_DESC(aac_check_reset, "If adapter fails health check, reset the" +MODULE_PARM_DESC(check_reset, "If adapter fails health check, reset the" " adapter. a value of -1 forces the reset to adapters programmed to" " ignore it."); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [AACRAID] Do not describe check_reset parameter with its value 2008-04-16 12:29 ` [PATCH] [AACRAID] Do not describe check_reset parameter with its value Mark Salyzyn @ 2008-04-16 12:43 ` Paul Bolle 2008-04-16 14:39 ` James Bottomley 0 siblings, 1 reply; 3+ messages in thread From: Paul Bolle @ 2008-04-16 12:43 UTC (permalink / raw) To: Mark Salyzyn; +Cc: Linux-Scsi From: Paul Bolle <pebolle@tiscali.nl> Do not describe check_reset parameter with its value Describe check_reset parameter with its name (and not its value) Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Mark Salyzyn <Mark_Salyzyn@adaptec.com> --- Reformatted patch (with Mark Salyzyn's sign-off added). diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index c05092f..43c7890 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -205,7 +205,7 @@ MODULE_PARM_DESC(check_interval, "Interval in seconds between adapter health" int aac_check_reset = 1; module_param_named(check_reset, aac_check_reset, int, S_IRUGO|S_IWUSR); -MODULE_PARM_DESC(aac_check_reset, "If adapter fails health check, reset the" +MODULE_PARM_DESC(check_reset, "If adapter fails health check, reset the" " adapter. a value of -1 forces the reset to adapters programmed to" " ignore it."); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [AACRAID] Do not describe check_reset parameter with its value 2008-04-16 12:43 ` Paul Bolle @ 2008-04-16 14:39 ` James Bottomley 0 siblings, 0 replies; 3+ messages in thread From: James Bottomley @ 2008-04-16 14:39 UTC (permalink / raw) To: Paul Bolle; +Cc: Mark Salyzyn, Linux-Scsi On Wed, 2008-04-16 at 14:43 +0200, Paul Bolle wrote: > From: Paul Bolle <pebolle@tiscali.nl> > > Do not describe check_reset parameter with its value > > Describe check_reset parameter with its name (and not its value) OK, added this, thanks. There's one slight problem I corrected: > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > Signed-off-by: Mark Salyzyn <Mark_Salyzyn@adaptec.com> This should be Acked-by not Signed-off-by. The rules are that Signed-off-by tracks the provenance of a patch (where it came from). So if you send the patch to Mark and he sends it to me, it would have his Signed-off-by because it went through his hands (and his tree). If Mark acks the patch, but you send it to me, then it gets an acked-by because it didn't actually pass through his hands. James ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-16 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1208334879.5614.34.camel@compaq.thuisdomein>
2008-04-16 12:29 ` [PATCH] [AACRAID] Do not describe check_reset parameter with its value Mark Salyzyn
2008-04-16 12:43 ` Paul Bolle
2008-04-16 14:39 ` James Bottomley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox