From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi_dh: rdac handler: Batch up MODE SELECTsand send few of them
Date: Thu, 07 May 2009 17:36:15 -0700 [thread overview]
Message-ID: <1241742975.27327.3.camel@chandra-ubuntu> (raw)
In-Reply-To: <4A02580A.2060704@cs.wisc.edu>
On Wed, 2009-05-06 at 22:39 -0500, Mike Christie wrote:
> Chandra Seetharaman wrote:
> > }
> >
> > -static int rdac_activate(struct scsi_device *sdev, activate_complete fn, void *data)
> > +static int queue_mode_select(struct scsi_device *sdev,
> > + activate_complete fn, void *data)
> > +{
> > + struct rdac_queue_data *qdata;
> > + struct rdac_controller *ctlr;
> > +
> > + qdata = kzalloc(sizeof(*qdata), GFP_KERNEL);
>
>
> I think you want to use GFP_NOIO or GFP_ATOMIC here. If GFP_NOIO can
> block and screw up other devices using that multipathd workqueue struct
> maybe GFP_ATOMIC would be best since we can have dm-mpath retry later.
Will do.
Thanks
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-08 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 2:52 [PATCH 0/3] scsi_dh: Make scsi_dh_activate asynchronous Chandra Seetharaman
2009-04-28 2:52 ` [PATCH 1/3] scsi_dh: Change the scsidh_activate interface to be asynchronous Chandra Seetharaman
2009-04-29 21:11 ` Moger, Babu
2009-04-28 2:52 ` [PATCH 2/3] scsi_dh: Remove the workqueue used for activate Chandra Seetharaman
2009-04-29 21:12 ` Moger, Babu
2009-05-07 3:32 ` Mike Christie
2009-05-08 0:35 ` [PATCH 2/3] scsi_dh: Remove the workqueue used foractivate Chandra Seetharaman
2009-05-08 3:09 ` Mike Christie
2009-05-08 5:25 ` [dm-devel] [PATCH 2/3] scsi_dh: Remove the workqueue usedforactivate Chandra Seetharaman
2009-04-28 2:52 ` [PATCH 3/3] scsi_dh: rdac handler: Batch up MODE SELECTs and send few of them Chandra Seetharaman
2009-04-29 21:12 ` Moger, Babu
2009-05-07 3:39 ` Mike Christie
2009-05-08 0:36 ` Chandra Seetharaman [this message]
2009-09-12 4:09 ` [dm-devel] [PATCH 3/3] scsi_dh: rdac handler: Batch up MODE SELECTsand " Shyam_Iyer
2009-09-14 19:25 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241742975.27327.3.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=sekharan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox