From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: linux-scsi <linux-scsi@vger.kernel.org>, Fubo Chen <fubo.chen@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter
Date: Sat, 22 Jan 2011 15:20:24 -0800 [thread overview]
Message-ID: <1295738425-4814-1-git-send-email-nab@linux-iscsi.org> (raw)
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch makes proc_mkdir() and remove_proc_entry() use a NULL
parameter to fix the following sparse warning:
CHECK drivers/target/target_core_configfs.c
drivers/target/target_core_configfs.c:3131:54: warning: Using plain integer as NULL pointer
drivers/target/target_core_configfs.c:3145:50: warning: Using plain integer as NULL pointer
drivers/target/target_core_configfs.c:3212:42: warning: Using plain integer as NULL pointer
Reported-by: Fubo Chen <fubo.chen@gmail.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
drivers/target/target_core_configfs.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 96b87da..10741e3 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -3158,7 +3158,7 @@ static int target_core_init_configfs(void)
if (core_dev_setup_virtual_lun0() < 0)
goto out;
- scsi_target_proc = proc_mkdir("scsi_target", 0);
+ scsi_target_proc = proc_mkdir("scsi_target", NULL);
if (!(scsi_target_proc)) {
printk(KERN_ERR "proc_mkdir(scsi_target, 0) failed\n");
goto out;
@@ -3172,7 +3172,7 @@ static int target_core_init_configfs(void)
out:
configfs_unregister_subsystem(subsys);
if (scsi_target_proc)
- remove_proc_entry("scsi_target", 0);
+ remove_proc_entry("scsi_target", NULL);
core_dev_release_virtual_lun0();
rd_module_exit();
out_global:
@@ -3239,7 +3239,7 @@ static void target_core_exit_configfs(void)
" Infrastructure\n");
remove_scsi_target_mib();
- remove_proc_entry("scsi_target", 0);
+ remove_proc_entry("scsi_target", NULL);
core_dev_release_virtual_lun0();
rd_module_exit();
release_se_global();
--
1.5.6.5
next reply other threads:[~2011-01-22 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 23:20 Nicholas A. Bellinger [this message]
2011-01-22 23:20 ` [PATCH] target: Convert backend ->create_virtdevice() call to return ERR_PTR Nicholas A. Bellinger
2011-01-23 14:12 ` [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter James Bottomley
2011-01-24 20:54 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295738425-4814-1-git-send-email-nab@linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=fubo.chen@gmail.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox