public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	Fubo Chen <fubo.chen@gmail.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter
Date: Sun, 23 Jan 2011 08:12:51 -0600	[thread overview]
Message-ID: <1295791971.3007.0.camel@mulgrave.site> (raw)
In-Reply-To: <1295738425-4814-1-git-send-email-nab@linux-iscsi.org>

On Sat, 2011-01-22 at 15:20 -0800, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> This patch makes proc_mkdir() and remove_proc_entry() use a NULL
> parameter to fix the following sparse warning:
> 
> CHECK   drivers/target/target_core_configfs.c
> drivers/target/target_core_configfs.c:3131:54: warning: Using plain integer as NULL pointer
> drivers/target/target_core_configfs.c:3145:50: warning: Using plain integer as NULL pointer
> drivers/target/target_core_configfs.c:3212:42: warning: Using plain integer as NULL pointer

Um, so I thought this interface was being replaced ... there's not a lot
of point in sparse fixing it.

James



  parent reply	other threads:[~2011-01-23 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22 23:20 [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter Nicholas A. Bellinger
2011-01-22 23:20 ` [PATCH] target: Convert backend ->create_virtdevice() call to return ERR_PTR Nicholas A. Bellinger
2011-01-23 14:12 ` James Bottomley [this message]
2011-01-24 20:54   ` [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295791971.3007.0.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=fubo.chen@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox