Re: [PATCH] target: Call proc_mkdir + remove_proc_entry with NULL parameter

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Sun, 2011-01-23 at 08:12 -0600, James Bottomley wrote:
> On Sat, 2011-01-22 at 15:20 -0800, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > This patch makes proc_mkdir() and remove_proc_entry() use a NULL
> > parameter to fix the following sparse warning:
> > 
> > CHECK   drivers/target/target_core_configfs.c
> > drivers/target/target_core_configfs.c:3131:54: warning: Using plain integer as NULL pointer
> > drivers/target/target_core_configfs.c:3145:50: warning: Using plain integer as NULL pointer
> > drivers/target/target_core_configfs.c:3212:42: warning: Using plain integer as NULL pointer
> 
> Um, so I thought this interface was being replaced ... there's not a lot
> of point in sparse fixing it.
> 

Hi James,

So my plan here is to move these statistics in /proc/scsi_target/ into
configfs specific contexts for TCM v4.1.  This also includes moving
iscsi_target_mod -> /proc/iscsi_target/ to use 
/sys/kernel/config/target/iscsi/ context attributes using our existing
CONFIGFS_EATTR() based macros in target_core_fabric_configfs.h
to provide the fabric dependent attributes.

So for target core this should be easy enough to split up short term in
'for-39', but the generic fabric statistics piece will require some new
logic that allows CONFIGFS_EATTR() macros to be seq_list() aware in
order to cat more than PAGE_SIZE for a individual configfs statistic
attribute some (one..?) special case. (jlbec CC'ed)

The reason we need this is to handle the N possible dynamic demo mode
struct se_node_acl (Initiator NodeACL) per TargetName+TargetPortalGroup
endpoint that we need for BKO ops.  (J.H CC'ed)

--nab