From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tomas Henzl <thenzl@redhat.com>
Cc: Viswas G <Viswas.G@pmcs.com>,
linux-scsi@vger.kernel.org, xjtuwjp@gmail.com,
Vasanthalakshmi.Tharmarajan@pmcs.com,
Suresh.Thiagarajan@pmcs.com
Subject: Re: [PATCH v2 2/2] pm80xx : Fixed return value issue
Date: Wed, 11 Dec 2013 11:47:00 -0800 [thread overview]
Message-ID: <1386791220.2109.0.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <52A89480.1010104@redhat.com>
On Wed, 2013-12-11 at 17:36 +0100, Tomas Henzl wrote:
> On 12/10/2013 06:01 AM, Viswas G wrote:
> > pm80xx_get_gsm_dump() was returning "1" in error case
> > instead of negative error value.
> >
> > Signed-off-by: Viswas G <Viswas.G@pmcs.com>
> > Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
> > Acked-by: TomasHenzl <thenzl@redhat.com>
>
> Hi Viswas,
>
> I've ack-ed a different patch before, so I don't think you should add that acked-by line.
> The V2 patch is fine for me too, so again -
> Acked-by: Tomas Henzl <thenzl@redhat.com>
Actually, it can't be acked-by; that's for maintainers agreeing to
patches not via them ... I assume it should be reviewed by?
James
prev parent reply other threads:[~2013-12-11 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 5:01 [PATCH v2 2/2] pm80xx : Fixed return value issue Viswas G
2013-12-11 16:36 ` Tomas Henzl
2013-12-11 19:47 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386791220.2109.0.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Suresh.Thiagarajan@pmcs.com \
--cc=Vasanthalakshmi.Tharmarajan@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox