[PATCH] hpsa: fix uninitialized variable

[PATCH] hpsa: fix uninitialized variable

[Hannes Reinecke]

With the recent patch to hpsa this warning is issued:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The patch that caused this is marked for stable backports,
so this one has to be backported on top as well.

Fixes: 4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 5834117..ac11201 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -2025,7 +2025,7 @@ static struct hpsa_scsi_dev_t *lookup_hpsa_scsi_dev(struct ctlr_info *h,
 
 static int hpsa_slave_alloc(struct scsi_device *sdev)
 {
-	struct hpsa_scsi_dev_t *sd;
+	struct hpsa_scsi_dev_t *sd = NULL;
 	unsigned long flags;
 	struct ctlr_info *h;
 
-- 
1.8.5.6

Re: [PATCH] hpsa: fix uninitialized variable

[Tomas Henzl]

On 22.11.2016 16:05, Hannes Reinecke wrote:
> With the recent patch to hpsa this warning is issued:
>
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The patch that caused this is marked for stable backports,
> so this one has to be backported on top as well.
>
> Fixes: 4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>

Looks good.

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas

Re: [PATCH] hpsa: fix uninitialized variable

[Arnd Bergmann]

On Tuesday, November 22, 2016 4:05:38 PM CET Hannes Reinecke wrote:
> With the recent patch to hpsa this warning is issued:
> 
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The patch that caused this is marked for stable backports,
> so this one has to be backported on top as well.
> 
> Fixes: 4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")
> 
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> 

Reported-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks!

	Arnd

Re: [PATCH] hpsa: fix uninitialized variable

[Martin K. Petersen]

>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:

Hannes> With the recent patch to hpsa this warning is issued:
Hannes> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Hannes> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used
Hannes> uninitialized in this function [-Werror=maybe-uninitialized]

I amended your original patch.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] hpsa: fix uninitialized variable

[Hannes Reinecke]

On 11/22/2016 10:57 PM, Martin K. Petersen wrote:
>>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:
> 
> Hannes> With the recent patch to hpsa this warning is issued:
> Hannes> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> Hannes> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used
> Hannes> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> I amended your original patch.
> 
Ta.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)