From: "Rob Herring (Arm)" <robh@kernel.org>
To: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
Cc: linux-kernel@vger.kernel.org, conor+dt@kernel.org,
martin.petersen@oracle.com, andersson@kernel.org,
taniya.das@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com,
krzk+dt@kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, nitin.rawat@oss.qualcomm.com,
konradybcio@kernel.org, linux-phy@lists.infradead.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC compatible for Hamoa
Date: Mon, 29 Dec 2025 01:35:17 -0600 [thread overview]
Message-ID: <176699371795.453334.1254086534957374498.robh@kernel.org> (raw)
In-Reply-To: <20251229060642.2807165-3-pradeep.pragallapati@oss.qualcomm.com>
On Mon, 29 Dec 2025 11:36:40 +0530, Pradeep P V K wrote:
> Document the UFSHC compatible for Qualcomm Hamoa SoC. Use fallback
> to indicate the compatibility of UFSHC on Hamoa with that on the
> SM8550.
>
> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
> ---
> .../devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.example.dtb: ufs@1d84000 (qcom,sm8450-ufshc): compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,sm8450-ufshc', 'qcom,ufshc', 'jedec,ufs-2.0'] is too long
'qcom,sm8450-ufshc' is not one of ['qcom,hamoa-ufshc']
'qcom,ufshc' was expected
'jedec,ufs-2.0' was expected
'qcom,sm8550-ufshc' was expected
from schema $id: http://devicetree.org/schemas/ufs/qcom,sc7180-ufshc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20251229060642.2807165-3-pradeep.pragallapati@oss.qualcomm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-12-29 7:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 6:06 [PATCH V1 0/4] Add UFS support for Hamoa SoC Pradeep P V K
2025-12-29 6:06 ` [PATCH V1 1/4] scsi: ufs: phy: dt-bindings: Add QMP UFS PHY compatible for Hamoa Pradeep P V K
2025-12-29 7:11 ` Krzysztof Kozlowski
2025-12-30 9:05 ` Pradeep Pragallapati
2025-12-30 9:38 ` Krzysztof Kozlowski
[not found] ` <d3d63b08-43ba-4b25-a939-416d5d647098@oss.qualcomm.com>
2025-12-30 12:08 ` Krzysztof Kozlowski
2025-12-29 12:26 ` Konrad Dybcio
2025-12-30 9:07 ` Pradeep Pragallapati
2025-12-29 6:06 ` [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC " Pradeep P V K
2025-12-29 7:13 ` Krzysztof Kozlowski
2025-12-29 12:20 ` Krzysztof Kozlowski
2025-12-30 8:54 ` Pradeep Pragallapati
2025-12-29 7:35 ` Rob Herring (Arm) [this message]
2025-12-29 6:06 ` [PATCH V1 3/4] arm64: dts: qcom: hamoa: Add UFS nodes for hamoa SoC Pradeep P V K
2025-12-29 12:15 ` Konrad Dybcio
2025-12-30 9:03 ` Pradeep Pragallapati
2025-12-29 6:06 ` [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS Pradeep P V K
2025-12-29 12:17 ` Konrad Dybcio
2025-12-30 8:58 ` Pradeep Pragallapati
2025-12-30 14:19 ` Konrad Dybcio
2025-12-30 14:48 ` Konrad Dybcio
2025-12-29 20:39 ` [PATCH V1 0/4] Add UFS support for Hamoa SoC Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176699371795.453334.1254086534957374498.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=taniya.das@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox