From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>,
vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
martin.petersen@oracle.com, andersson@kernel.org,
konradybcio@kernel.org, taniya.das@oss.qualcomm.com,
dmitry.baryshkov@oss.qualcomm.com
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, nitin.rawat@oss.qualcomm.com
Subject: Re: [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC compatible for Hamoa
Date: Mon, 29 Dec 2025 13:20:51 +0100 [thread overview]
Message-ID: <26bed077-8450-40ec-97f3-50b7771e4c9b@kernel.org> (raw)
In-Reply-To: <9d3c21ad-c265-4e22-b804-ef8c39b7e787@kernel.org>
On 29/12/2025 08:13, Krzysztof Kozlowski wrote:
> On 29/12/2025 07:06, Pradeep P V K wrote:
>> Document the UFSHC compatible for Qualcomm Hamoa SoC. Use fallback
>> to indicate the compatibility of UFSHC on Hamoa with that on the
>> SM8550.
>
> Same problem.
>
>>
>> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>> index d94ef4e6b85a..3b5a95db7831 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>
> That's older devices binding. Why would Hamoa fit here?
... and why even bothering with testing this? Every internal guide tells
you this yet you sent it untested.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-29 12:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 6:06 [PATCH V1 0/4] Add UFS support for Hamoa SoC Pradeep P V K
2025-12-29 6:06 ` [PATCH V1 1/4] scsi: ufs: phy: dt-bindings: Add QMP UFS PHY compatible for Hamoa Pradeep P V K
2025-12-29 7:11 ` Krzysztof Kozlowski
2025-12-30 9:05 ` Pradeep Pragallapati
2025-12-30 9:38 ` Krzysztof Kozlowski
[not found] ` <d3d63b08-43ba-4b25-a939-416d5d647098@oss.qualcomm.com>
2025-12-30 12:08 ` Krzysztof Kozlowski
2025-12-29 12:26 ` Konrad Dybcio
2025-12-30 9:07 ` Pradeep Pragallapati
2025-12-29 6:06 ` [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC " Pradeep P V K
2025-12-29 7:13 ` Krzysztof Kozlowski
2025-12-29 12:20 ` Krzysztof Kozlowski [this message]
2025-12-30 8:54 ` Pradeep Pragallapati
2025-12-29 7:35 ` Rob Herring (Arm)
2025-12-29 6:06 ` [PATCH V1 3/4] arm64: dts: qcom: hamoa: Add UFS nodes for hamoa SoC Pradeep P V K
2025-12-29 12:15 ` Konrad Dybcio
2025-12-30 9:03 ` Pradeep Pragallapati
2025-12-29 6:06 ` [PATCH V1 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS Pradeep P V K
2025-12-29 12:17 ` Konrad Dybcio
2025-12-30 8:58 ` Pradeep Pragallapati
2025-12-30 14:19 ` Konrad Dybcio
2025-12-30 14:48 ` Konrad Dybcio
2025-12-29 20:39 ` [PATCH V1 0/4] Add UFS support for Hamoa SoC Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26bed077-8450-40ec-97f3-50b7771e4c9b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox