Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
	Arun Easi <aeasi@marvell.com>, Daniel Wagner <dwagner@suse.de>,
	Nilesh Javali <njavali@marvell.com>,
	Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>,
	Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH v6 06/15] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit
Date: Fri, 15 May 2020 10:44:53 -0500	[thread overview]
Message-ID: <1780ae48-5865-a5d0-51d5-ebf8f0b83ab9@oracle.com> (raw)
In-Reply-To: <20200514213516.25461-7-bvanassche@acm.org>



On 5/14/20 4:35 PM, Bart Van Assche wrote:
> This patch makes struct qla2xxx_offld_chain compatible with ARCH=i386.
> 
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Arun Easi <aeasi@marvell.com>
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
> Cc: Quinn Tran <qutran@marvell.com>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   drivers/scsi/qla2xxx/qla_dbg.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
> index 433e95502808..b106b6808d34 100644
> --- a/drivers/scsi/qla2xxx/qla_dbg.h
> +++ b/drivers/scsi/qla2xxx/qla_dbg.h
> @@ -238,6 +238,7 @@ struct qla2xxx_offld_chain {
>   	uint32_t chain_size;
>   
>   	uint32_t size;
> +	uint32_t reserved;
>   	u64	 addr;
>   };
>   
> 
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani
Oracle Linux Engineering

  reply	other threads:[~2020-05-15 15:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 21:35 [PATCH v6 00/15] Fix qla2xxx endianness annotations Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 01/15] qla2xxx: Fix spelling of a variable name Bart Van Assche
2020-05-15 23:05   ` Roman Bolshakov
2020-05-14 21:35 ` [PATCH v6 02/15] qla2xxx: Suppress two recently introduced compiler warnings Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 03/15] qla2xxx: Simplify the functions for dumping firmware Bart Van Assche
2020-05-15  6:38   ` Hannes Reinecke
2020-05-15  7:57   ` Daniel Wagner
2020-05-14 21:35 ` [PATCH v6 04/15] qla2xxx: Sort BUILD_BUG_ON() statements alphabetically Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 05/15] qla2xxx: Add more BUILD_BUG_ON() statements Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 06/15] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit Bart Van Assche
2020-05-15 15:44   ` Himanshu Madhani [this message]
2020-05-14 21:35 ` [PATCH v6 07/15] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 08/15] qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressions Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 09/15] qla2xxx: Use register names instead of register offsets Bart Van Assche
2020-05-15  8:25   ` Daniel Wagner
2020-05-15 15:54   ` Himanshu Madhani
2020-05-14 21:35 ` [PATCH v6 10/15] qla2xxx: Fix the code that reads from mailbox registers Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 11/15] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 12/15] qla2xxx: Cast explicitly to uint16_t / uint32_t Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 13/15] qla2xxx: Use make_handle() instead of open-coding it Bart Van Assche
2020-05-15  6:39   ` Hannes Reinecke
2020-05-15  8:28   ` Daniel Wagner
2020-05-15 15:58   ` Himanshu Madhani
2020-05-15 22:55   ` Roman Bolshakov
2020-05-14 21:35 ` [PATCH v6 14/15] qla2xxx: Fix endianness annotations in header files Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 15/15] qla2xxx: Fix endianness annotations in source files Bart Van Assche
2020-05-15  6:50   ` Hannes Reinecke
2020-05-15 19:22     ` Bart Van Assche
2020-05-18  6:18       ` Hannes Reinecke
2020-05-15  9:44   ` Daniel Wagner
2020-05-18 21:13     ` Bart Van Assche
2020-05-19 15:27       ` Daniel Wagner
2020-05-19 16:17         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1780ae48-5865-a5d0-51d5-ebf8f0b83ab9@oracle.com \
    --to=himanshu.madhani@oracle.com \
    --cc=aeasi@marvell.com \
    --cc=bvanassche@acm.org \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=njavali@marvell.com \
    --cc=qutran@marvell.com \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox