From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Arun Easi <aeasi@marvell.com>,
Nilesh Javali <njavali@marvell.com>,
Daniel Wagner <dwagner@suse.de>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Martin Wilck <mwilck@suse.com>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH v6 03/15] qla2xxx: Simplify the functions for dumping firmware
Date: Fri, 15 May 2020 08:38:05 +0200 [thread overview]
Message-ID: <de66ff0c-e5eb-346c-ee46-a7ed245f7a9f@suse.de> (raw)
In-Reply-To: <20200514213516.25461-4-bvanassche@acm.org>
On 5/14/20 11:35 PM, Bart Van Assche wrote:
> Instead of passing an argument to the firmware dumping functions that
> tells these functions whether or not to obtain the hardware lock, obtain
> that lock before calling these functions. This patch fixes the following
> recently introduced C=2 build error:
>
> CHECK drivers/scsi/qla2xxx/qla_tmpl.c
> drivers/scsi/qla2xxx/qla_tmpl.c:1133:1: error: Expected ; at end of statement
> drivers/scsi/qla2xxx/qla_tmpl.c:1133:1: error: got }
> drivers/scsi/qla2xxx/qla_tmpl.h:247:0: error: Expected } at end of function
> drivers/scsi/qla2xxx/qla_tmpl.h:247:0: error: got end-of-input
>
> Cc: Arun Easi <aeasi@marvell.com>
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: Daniel Wagner <dwagner@suse.de>
> Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 4 +-
> drivers/scsi/qla2xxx/qla_dbg.c | 153 ++++++++----------------------
> drivers/scsi/qla2xxx/qla_def.h | 2 +-
> drivers/scsi/qla2xxx/qla_gbl.h | 21 ++--
> drivers/scsi/qla2xxx/qla_isr.c | 12 +--
> drivers/scsi/qla2xxx/qla_mbx.c | 6 +-
> drivers/scsi/qla2xxx/qla_nx.c | 2 +-
> drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> drivers/scsi/qla2xxx/qla_target.c | 4 +-
> drivers/scsi/qla2xxx/qla_tmpl.c | 19 +---
> 11 files changed, 71 insertions(+), 156 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-05-15 6:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 21:35 [PATCH v6 00/15] Fix qla2xxx endianness annotations Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 01/15] qla2xxx: Fix spelling of a variable name Bart Van Assche
2020-05-15 23:05 ` Roman Bolshakov
2020-05-14 21:35 ` [PATCH v6 02/15] qla2xxx: Suppress two recently introduced compiler warnings Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 03/15] qla2xxx: Simplify the functions for dumping firmware Bart Van Assche
2020-05-15 6:38 ` Hannes Reinecke [this message]
2020-05-15 7:57 ` Daniel Wagner
2020-05-14 21:35 ` [PATCH v6 04/15] qla2xxx: Sort BUILD_BUG_ON() statements alphabetically Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 05/15] qla2xxx: Add more BUILD_BUG_ON() statements Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 06/15] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit Bart Van Assche
2020-05-15 15:44 ` Himanshu Madhani
2020-05-14 21:35 ` [PATCH v6 07/15] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 08/15] qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressions Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 09/15] qla2xxx: Use register names instead of register offsets Bart Van Assche
2020-05-15 8:25 ` Daniel Wagner
2020-05-15 15:54 ` Himanshu Madhani
2020-05-14 21:35 ` [PATCH v6 10/15] qla2xxx: Fix the code that reads from mailbox registers Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 11/15] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 12/15] qla2xxx: Cast explicitly to uint16_t / uint32_t Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 13/15] qla2xxx: Use make_handle() instead of open-coding it Bart Van Assche
2020-05-15 6:39 ` Hannes Reinecke
2020-05-15 8:28 ` Daniel Wagner
2020-05-15 15:58 ` Himanshu Madhani
2020-05-15 22:55 ` Roman Bolshakov
2020-05-14 21:35 ` [PATCH v6 14/15] qla2xxx: Fix endianness annotations in header files Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 15/15] qla2xxx: Fix endianness annotations in source files Bart Van Assche
2020-05-15 6:50 ` Hannes Reinecke
2020-05-15 19:22 ` Bart Van Assche
2020-05-18 6:18 ` Hannes Reinecke
2020-05-15 9:44 ` Daniel Wagner
2020-05-18 21:13 ` Bart Van Assche
2020-05-19 15:27 ` Daniel Wagner
2020-05-19 16:17 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de66ff0c-e5eb-346c-ee46-a7ed245f7a9f@suse.de \
--to=hare@suse.de \
--cc=aeasi@marvell.com \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox