From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
<linux-scsi@vger.kernel.org>, Hannes Reinecke <hare@suse.de>,
Arun Easi <aeasi@marvell.com>, Daniel Wagner <dwagner@suse.de>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v6 01/15] qla2xxx: Fix spelling of a variable name
Date: Sat, 16 May 2020 02:05:32 +0300 [thread overview]
Message-ID: <20200515230532.GH98158@SPB-NB-133.local> (raw)
In-Reply-To: <20200514213516.25461-2-bvanassche@acm.org>
On Thu, May 14, 2020 at 02:35:02PM -0700, Bart Van Assche wrote:
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Arun Easi <aeasi@marvell.com>
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: Quinn Tran <qutran@marvell.com>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/qla2xxx/qla_fw.h | 2 +-
> drivers/scsi/qla2xxx/qla_init.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx/qla_fw.h
> index f9bad5bd7198..b364a497e33d 100644
> --- a/drivers/scsi/qla2xxx/qla_fw.h
> +++ b/drivers/scsi/qla2xxx/qla_fw.h
> @@ -1292,7 +1292,7 @@ struct device_reg_24xx {
> };
> /* RISC-RISC semaphore register PCI offet */
> #define RISC_REGISTER_BASE_OFFSET 0x7010
> -#define RISC_REGISTER_WINDOW_OFFET 0x6
> +#define RISC_REGISTER_WINDOW_OFFSET 0x6
>
> /* RISC-RISC semaphore/flag register (risc address 0x7016) */
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 95b6166ae0cc..f8fe0334571f 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -2861,7 +2861,7 @@ qla25xx_read_risc_sema_reg(scsi_qla_host_t *vha, uint32_t *data)
> struct device_reg_24xx __iomem *reg = &vha->hw->iobase->isp24;
>
> WRT_REG_DWORD(®->iobase_addr, RISC_REGISTER_BASE_OFFSET);
> - *data = RD_REG_DWORD(®->iobase_window + RISC_REGISTER_WINDOW_OFFET);
> + *data = RD_REG_DWORD(®->iobase_window + RISC_REGISTER_WINDOW_OFFSET);
>
> }
>
> @@ -2871,7 +2871,7 @@ qla25xx_write_risc_sema_reg(scsi_qla_host_t *vha, uint32_t data)
> struct device_reg_24xx __iomem *reg = &vha->hw->iobase->isp24;
>
> WRT_REG_DWORD(®->iobase_addr, RISC_REGISTER_BASE_OFFSET);
> - WRT_REG_DWORD(®->iobase_window + RISC_REGISTER_WINDOW_OFFET, data);
> + WRT_REG_DWORD(®->iobase_window + RISC_REGISTER_WINDOW_OFFSET, data);
> }
>
> static void
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Thanks,
Roman
next prev parent reply other threads:[~2020-05-15 23:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 21:35 [PATCH v6 00/15] Fix qla2xxx endianness annotations Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 01/15] qla2xxx: Fix spelling of a variable name Bart Van Assche
2020-05-15 23:05 ` Roman Bolshakov [this message]
2020-05-14 21:35 ` [PATCH v6 02/15] qla2xxx: Suppress two recently introduced compiler warnings Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 03/15] qla2xxx: Simplify the functions for dumping firmware Bart Van Assche
2020-05-15 6:38 ` Hannes Reinecke
2020-05-15 7:57 ` Daniel Wagner
2020-05-14 21:35 ` [PATCH v6 04/15] qla2xxx: Sort BUILD_BUG_ON() statements alphabetically Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 05/15] qla2xxx: Add more BUILD_BUG_ON() statements Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 06/15] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit Bart Van Assche
2020-05-15 15:44 ` Himanshu Madhani
2020-05-14 21:35 ` [PATCH v6 07/15] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 08/15] qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressions Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 09/15] qla2xxx: Use register names instead of register offsets Bart Van Assche
2020-05-15 8:25 ` Daniel Wagner
2020-05-15 15:54 ` Himanshu Madhani
2020-05-14 21:35 ` [PATCH v6 10/15] qla2xxx: Fix the code that reads from mailbox registers Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 11/15] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 12/15] qla2xxx: Cast explicitly to uint16_t / uint32_t Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 13/15] qla2xxx: Use make_handle() instead of open-coding it Bart Van Assche
2020-05-15 6:39 ` Hannes Reinecke
2020-05-15 8:28 ` Daniel Wagner
2020-05-15 15:58 ` Himanshu Madhani
2020-05-15 22:55 ` Roman Bolshakov
2020-05-14 21:35 ` [PATCH v6 14/15] qla2xxx: Fix endianness annotations in header files Bart Van Assche
2020-05-14 21:35 ` [PATCH v6 15/15] qla2xxx: Fix endianness annotations in source files Bart Van Assche
2020-05-15 6:50 ` Hannes Reinecke
2020-05-15 19:22 ` Bart Van Assche
2020-05-18 6:18 ` Hannes Reinecke
2020-05-15 9:44 ` Daniel Wagner
2020-05-18 21:13 ` Bart Van Assche
2020-05-19 15:27 ` Daniel Wagner
2020-05-19 16:17 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515230532.GH98158@SPB-NB-133.local \
--to=r.bolshakov@yadro.com \
--cc=aeasi@marvell.com \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox