Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
Subject: Re: [PATCH v6 11/11] scsi: ufs: core: Move code out of an if-statement
Date: Tue, 5 Nov 2024 14:01:05 -0800	[thread overview]
Message-ID: <1c9acc01-7b1d-41ac-a0da-4e50dc8f0319@acm.org> (raw)
In-Reply-To: <6b20595d-c7f6-42aa-922e-3671abd7917c@acm.org>

On 10/31/24 2:15 PM, Bart Van Assche wrote:
> On 10/31/24 12:55 PM, Neil Armstrong wrote:
>> Le 31/10/2024 à 18:51, Bart Van Assche a écrit :
>>> Is the patch below sufficient to fix both issues?
>>
>> Yes it does!
> 
> Thank you for having tested this patch quickly. Would it be possible
> to test whether the patch below also fixes the reported boot failure?
> I think the patch below is a better fix.
> 
> Thanks,
> 
> Bart.
> 
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index a5a0646bb80a..3b592492e152 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -874,7 +874,8 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba 
> *hba)
>       if (host->hw_ver.major > 0x3)
>           hba->quirks |= UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH;
> 
> -    if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc"))
> +    if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc") ||
> +        of_device_is_compatible(hba->dev->of_node, "qcom,sm8650-ufshc"))
>           hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP;
>   }

(replying to my own email)

Can anyone who has access to a Qualcomm SM8650 Platform please help with
testing the above patch on top of linux-next?

Thanks,

Bart.

  reply	other threads:[~2024-11-05 22:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 20:11 [PATCH v6 00/11] Combine the two UFS driver scsi_add_host() calls Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 01/11] scsi: ufs: core: Introduce ufshcd_add_scsi_host() Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 02/11] scsi: ufs: core: Introduce ufshcd_post_device_init() Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 03/11] scsi: ufs: core: Call ufshcd_add_scsi_host() later Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 04/11] scsi: ufs: core: Introduce ufshcd_process_probe_result() Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 05/11] scsi: ufs: core: Convert a comment into an explicit check Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 06/11] scsi: ufs: core: Move the ufshcd_device_init() calls Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 07/11] scsi: ufs: core: Move the ufshcd_device_init(hba, true) call Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 08/11] scsi: ufs: core: Expand " Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 09/11] scsi: ufs: core: Remove code that is no longer needed Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 10/11] scsi: ufs: core: Move the MCQ scsi_add_host() call Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 11/11] scsi: ufs: core: Move code out of an if-statement Bart Van Assche
2024-10-31 14:46   ` Neil Armstrong
2024-10-31 17:51     ` Bart Van Assche
2024-10-31 19:55       ` Neil Armstrong
2024-10-31 21:15         ` Bart Van Assche
2024-11-05 22:01           ` Bart Van Assche [this message]
2024-11-06  8:48             ` Neil Armstrong
2024-11-06  9:57             ` Neil Armstrong
2024-11-06 17:51               ` Bart Van Assche
2024-11-07 10:49                 ` Manivannan Sadhasivam
2024-10-25 19:30 ` [PATCH v6 00/11] Combine the two UFS driver scsi_add_host() calls Martin K. Petersen
2024-11-05  2:32 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c9acc01-7b1d-41ac-a0da-4e50dc8f0319@acm.org \
    --to=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox