Re: [PATCH v6 11/11] scsi: ufs: core: Move code out of an if-statement

[Neil Armstrong <neil.armstrong@linaro.org>]

+ Mani

On 05/11/2024 23:01, Bart Van Assche wrote:
> On 10/31/24 2:15 PM, Bart Van Assche wrote:
>> On 10/31/24 12:55 PM, Neil Armstrong wrote:
>>> Le 31/10/2024 à 18:51, Bart Van Assche a écrit :
>>>> Is the patch below sufficient to fix both issues?
>>>
>>> Yes it does!
>>
>> Thank you for having tested this patch quickly. Would it be possible
>> to test whether the patch below also fixes the reported boot failure?
>> I think the patch below is a better fix.
>>
>> Thanks,
>>
>> Bart.
>>
>>
>> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>> index a5a0646bb80a..3b592492e152 100644
>> --- a/drivers/ufs/host/ufs-qcom.c
>> +++ b/drivers/ufs/host/ufs-qcom.c
>> @@ -874,7 +874,8 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba)
>>       if (host->hw_ver.major > 0x3)
>>           hba->quirks |= UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH;
>>
>> -    if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc"))
>> +    if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc") ||
>> +        of_device_is_compatible(hba->dev->of_node, "qcom,sm8650-ufshc"))
>>           hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP;
>>   }
> 
> (replying to my own email)
> 
> Can anyone who has access to a Qualcomm SM8650 Platform please help with
> testing the above patch on top of linux-next?
> 
> Thanks,
> 
> Bart.

Thanks, it does fix the issue. But it won't scale since the next platforms will
probably need the same tweak in the future.

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD

Thanks,
Neil