From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: neil.armstrong@linaro.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>
Subject: Re: [PATCH v6 11/11] scsi: ufs: core: Move code out of an if-statement
Date: Thu, 7 Nov 2024 10:49:58 +0000 [thread overview]
Message-ID: <20241107104958.ufanaxocws2dmdwq@thinkpad> (raw)
In-Reply-To: <79516d73-7ca1-4af7-87cb-d8d87d4dc6ac@acm.org>
On Wed, Nov 06, 2024 at 09:51:06AM -0800, Bart Van Assche wrote:
> On 11/6/24 1:57 AM, Neil Armstrong wrote:
> > Thanks, it does fix the issue. But it won't scale since the next
> > platforms will probably need the same tweak in the future.
> >
> > Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
> > Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
>
> Hi Neil,
>
> Thanks for testing!
>
> The comment about future platforms is not clear to me. This patch fixes
> support for a non-standard controller (reports UFSHCI version 4 but
> supports UFSHCI 3 register set). Shouldn't all future platforms support
> the UFSHCI 4 register set?
>
Yeah, the future platforms should (hopefully) no longer have this issue.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-11-07 10:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 20:11 [PATCH v6 00/11] Combine the two UFS driver scsi_add_host() calls Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 01/11] scsi: ufs: core: Introduce ufshcd_add_scsi_host() Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 02/11] scsi: ufs: core: Introduce ufshcd_post_device_init() Bart Van Assche
2024-10-16 20:11 ` [PATCH v6 03/11] scsi: ufs: core: Call ufshcd_add_scsi_host() later Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 04/11] scsi: ufs: core: Introduce ufshcd_process_probe_result() Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 05/11] scsi: ufs: core: Convert a comment into an explicit check Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 06/11] scsi: ufs: core: Move the ufshcd_device_init() calls Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 07/11] scsi: ufs: core: Move the ufshcd_device_init(hba, true) call Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 08/11] scsi: ufs: core: Expand " Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 09/11] scsi: ufs: core: Remove code that is no longer needed Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 10/11] scsi: ufs: core: Move the MCQ scsi_add_host() call Bart Van Assche
2024-10-16 20:12 ` [PATCH v6 11/11] scsi: ufs: core: Move code out of an if-statement Bart Van Assche
2024-10-31 14:46 ` Neil Armstrong
2024-10-31 17:51 ` Bart Van Assche
2024-10-31 19:55 ` Neil Armstrong
2024-10-31 21:15 ` Bart Van Assche
2024-11-05 22:01 ` Bart Van Assche
2024-11-06 8:48 ` Neil Armstrong
2024-11-06 9:57 ` Neil Armstrong
2024-11-06 17:51 ` Bart Van Assche
2024-11-07 10:49 ` Manivannan Sadhasivam [this message]
2024-10-25 19:30 ` [PATCH v6 00/11] Combine the two UFS driver scsi_add_host() calls Martin K. Petersen
2024-11-05 2:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107104958.ufanaxocws2dmdwq@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox